Repository navigation
bpo-20180: itertools.groupby Argument Clinic conversion - #4170
Merged
rhettinger merged 7 commits intoSep 10, 2018
Merged
rhettinger merged 7 commits into
rhettinger merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@rhettinger, do you think you'll have time to review this any time soon, or should I try to find another reviewer? |
Sorry, something went wrong.
taleinat
force-pushed
the
bpo-20180_itertools_groupby_AC_conversion
branch
from
9cdb562 to
683cfd9
Compare
July 1, 2018 05:41
Copy link
Copy Markdown
Contributor
Author
|
Rebased on current master. |
Sorry, something went wrong.
…to the original positions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a small part of the changes from PR #4117, which applies an extensive Argument Clinic conversion to all of Modules/itertoolsmodule.c.
In an effort to streamline the process of reviewing that conversion, this PR only converts the groupby class and the internal _grouper helper class. It also only converts the constructors, avoiding conversion of private methods such as __reduce__ and __setstate__. Finally, it minimizes the doc-string changes, whereas the original PR mentioned above made significant changes to doc-strings in some cases.
https://bugs.python.org/issue20180