FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[2.7] bpo-30806: Fix netrc.__repr__() format (GH-2491) by sloria · Pull Request #4276 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[2.7] bpo-30806: Fix netrc.__repr__() format (GH-2491) - #4276

Merged
methane merged 3 commits into
python:2.7from
sloria:backport-bpo-30806-fix
Dec 10, 2017
ConversationCommits (3)ChecksFiles changed
Merged

[2.7] bpo-30806: Fix netrc.__repr__() format (GH-2491)#4276
methane merged 3 commits into
python:2.7from
sloria:backport-bpo-30806-fix

Conversation

sloria commented Nov 4, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

Backports the fix for https://bugs.python.org/issue30806 and updates the syntax for Python 2.7 compatibility.

https://bugs.python.org/issue30806

sloria mentioned this pull request Nov 4, 2017
Merged
sloria force-pushed the backport-bpo-30806-fix branch from 8e6e688 to 247057d Compare November 4, 2017 17:21
methane changed the title [2.7] bpo-30806 netrc.__repr__() is broken for writing to file (GH-2491) [2.7] bpo-30806: Fix netrc.__repr__() format (GH-2491) Nov 6, 2017

methane commented Nov 6, 2017

Copy link
Copy Markdown
Member

test is failing on Windows.

sloria commented Nov 6, 2017

Copy link
Copy Markdown
Author

@methane Yeah, I saw that, but I'm not quite sure why it's happening. All I did was cherry-pick the fix and the test from #2491. Any help would be appreciated.

methane commented Nov 7, 2017

Copy link
Copy Markdown
Member

Yes, that's why I don't want to backport it by myself. Backporting to 2.7 requires significant efforts.
Python 2.7 and 3 are different. netrc in 2.7 and 3 are different too. Just cherry-pick is not enough.

I don't have time and motivation about thinking about how to backport it. I'm very busy in these
months, sorry.

methane reviewed Nov 7, 2017
View reviewed changes
Comment thread Lib/test/test_netrc.py Outdated

methane Nov 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe, reverting this change may fix the error.

methane Nov 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Don't forget to remove import tempfile when reverting this.

sloria commented Nov 7, 2017 •
edited
Loading

Copy link
Copy Markdown
Author

@methane I understand. No worries; I'm also busier than usual these days, but I'll take a look at those Windows tests when I have time.

sloria force-pushed the backport-bpo-30806-fix branch from 247057d to 72d9096 Compare December 9, 2017 17:11
sloria force-pushed the backport-bpo-30806-fix branch from 72d9096 to 40b0005 Compare December 9, 2017 17:41

sloria commented Dec 9, 2017

Copy link
Copy Markdown
Author

@methane Thanks for the tip with the tests. All green now!

methane merged commit 3b9173d into python:2.7 Dec 10, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

methane methane left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL