FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-76183: Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale by embray · Pull Request #4361 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-76183: Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale - #4361

Closed
embray wants to merge 1 commit into
python:mainfrom
embray:cygwin/test-c-locale-coercion
ConversationCommits (1)ChecksFiles changed
Closed

gh-76183: Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale#4361
embray wants to merge 1 commit into
python:mainfrom
embray:cygwin/test-c-locale-coercion

Conversation

embray commented Nov 10, 2017 •
edited by erlend-aasland
Loading

Copy link
Copy Markdown
Contributor

Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale

ncoghlan reviewed Nov 10, 2017
View reviewed changes
Comment thread Lib/test/test_c_locale_coercion.py Outdated

ncoghlan Nov 10, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Typo in the comment: enivornment -> environment

embray Nov 10, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Heh, I'll just fix that and squash...

embray force-pushed the cygwin/test-c-locale-coercion branch from 91f7983 to 5f6d3a0 Compare November 10, 2017 11:17
xdegaye suggested changes Nov 11, 2017
View reviewed changes
Comment thread Lib/test/test_c_locale_coercion.py
result.fail(py_cmd)

DEFAULT_LC_CTYPE = result.out.decode("ascii").strip().upper()

xdegaye Nov 11, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Did you try setting C_LOCALE_STREAM_ENCODING to "utf-8" instead ?

Comment thread Lib/test/test_c_locale_coercion.py
# See https://bugs.python.org/issue30672 for discussion
if locale_to_set == "POSIX":
continue
elif locale_to_set == "" and DEFAULT_LC_CTYPE == "C.UTF-8":

xdegaye Nov 11, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The condition is too restrictive:

  • When locale_to_set is "" and a locale envt variable exists in extra_vars with a non empty string (for example in test_LC_ALL_set_to_C), the subtest may be run.
  • It seems that when C_LOCALE_STREAM_ENCODING is set to "utf-8" and coerce_c_localecoerce_c_locale is not "warn" then the test should pass.

bedevere-bot commented Nov 11, 2017

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

embray mentioned this pull request Nov 13, 2017
Merged
embray mentioned this pull request Apr 10, 2022
Closed

github-actions Bot commented Aug 13, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Aug 13, 2022

erlend-aasland commented Jan 23, 2023

Copy link
Copy Markdown
Contributor

@embray: are you planning on following up this PR/issue?

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jan 24, 2023

github-actions Bot commented Feb 23, 2023

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 23, 2023
erlend-aasland changed the title bpo-32002 Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale gh-76183: Fix legacy locale coercion tests on platforms that already have a default C.UTF-8 locale Feb 23, 2023
erlend-aasland added the pending The issue will be closed if no feedback is provided label Feb 23, 2023

erlend-aasland commented Feb 23, 2023

Copy link
Copy Markdown
Contributor

After one month, still no response. Suggesting to close this PR and the related issue (Cygwin is not supported).

github-actions Bot removed the stale Stale PR or inactive for long period of time. label Feb 24, 2023

arhadthedev commented Mar 4, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

@embray Could you address the reviews please?

github-actions Bot commented Apr 4, 2023

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 4, 2023
erlend-aasland removed the pending The issue will be closed if no feedback is provided label Apr 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ncoghlan ncoghlan left review comments
+1 more reviewer
xdegaye xdegaye requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes stale Stale PR or inactive for long period of time.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL