FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-31643: test_uuid: allow zero MAC address by native-api · Pull Request #4448 · python/cpython · GitHub

/ cpython Public

bpo-31643: test_uuid: allow zero MAC address #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
native-api wants to merge 4 commits into from
Conversation 0 Commits 4 Checks 0 Files changed
Closed

bpo-31643: test_uuid: allow zero MAC address #4448

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4d1417
Allows for all-zero MAC address (e.g. mobile modem)
native-api Nov 18, 2017
0b4a2fa
node from _windll_getnode is always MAC-based
native-api Nov 18, 2017
07c8971
-duplication
native-api Nov 18, 2017
8d4745c
Merge branch 'master' into test_uuid_zero_mac
native-api Dec 11, 2017
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
10 changes: 7 additions & 3 deletions Lib/test/test_uuid.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ def test_exceptions(self):

def test_getnode(self):
node1 = self.uuid.getnode()
self.assertTrue(0 < node1 < (1 << 48), '%012x' % node1)
self.check_node(node1)

# Test it again to ensure consistency.
node2 = self.uuid.getnode()
Expand Down Expand Up @@ -518,7 +518,11 @@ def check_node(self, node, requires=None):
hex = '%012x' % node
if support.verbose >= 2:
print(hex, end=' ')
self.assertTrue(0 < node < (1 << 48),
if network:
# 47 bit will never be set in IEEE 802 addresses obtained
# from network cards.
self.assertFalse(node & 0x010000000000, hex)
self.assertTrue(0 <= node < (1 << 48),
"%s is not an RFC 4122 node ID" % hex)

@unittest.skipUnless(os.name == 'posix', 'requires Posix')
Expand Down Expand Up @@ -582,7 +586,7 @@ def test_unix_getnode(self):
@unittest.skipUnless(importable('ctypes'), 'requires ctypes')
def test_windll_getnode(self):
node = self.uuid._windll_getnode()
self.check_node(node)
self.check_node(node, network=True)


class TestInternalsWithoutExtModule(BaseTestInternals, unittest.TestCase):
Expand Down
Back | FazBrowse Home | New Git URL