FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-20891: Py_Initialize() now creates the GIL by vstinner · Pull Request #4700 · python/cpython · GitHub

/ cpython Public

bpo-20891: Py_Initialize() now creates the GIL - #4700

Merged
vstinner merged 4 commits into
python:masterfrom
vstinner:gil_created
Jan 29, 2018
ConversationCommits (4)ChecksFiles changed
Merged

bpo-20891: Py_Initialize() now creates the GIL#4700
vstinner merged 4 commits into
python:masterfrom
vstinner:gil_created

Conversation

vstinner commented Dec 4, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

The GIL is not more created "on demand" to fix a race condition when
PyGILState_Ensure() is called in a non-Python thread.

https://bugs.python.org/issue20891

vstinner requested a review from pitrou December 4, 2017 17:35
pitrou reviewed Dec 4, 2017
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2017-12-04-18-34-11.bpo-20891.C2TsfR.rst Outdated

pitrou Dec 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

s/not more/no more/

vstinner Dec 4, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

oops, replaced with "no longer"

pitrou commented Dec 4, 2017

Copy link
Copy Markdown
Member

Is there any documentation to update?

vstinner commented Dec 4, 2017

Copy link
Copy Markdown
Member Author

Is there any documentation to update?

Done, see my updated PR.

pitrou reviewed Dec 4, 2017
View reviewed changes
Comment thread Doc/c-api/init.rst Outdated

pitrou Dec 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would phrase it more explicitly:

This function is now called by :c:func:`Py_Initialize()`, so you don't have to call it yourself anymore.

vstinner Jan 29, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done

warsaw commented Dec 15, 2017

Copy link
Copy Markdown
Member

This branch seems to fix the issue for me on macOS 10.12.6

vstinner commented Dec 18, 2017

Copy link
Copy Markdown
Member Author

For benchmark results, see https://bugs.python.org/issue20891#msg308588

bpo-20891: Py_Initialize() now creates the GIL
8cd30d6 
The GIL is no longer created "on demand" to fix a race condition when
PyGILState_Ensure() is called in a non-Python thread.
Update the documentation
ec26869 
Remove also mention of the "thread support", since thread support
cannot be disabled anymore.
Simplify PyEval_SaveThread/PyEval_RestoreThread
0caeef0 
Make the assumption that the GIL is always created (by
Py_Initialize()).
doc: rephrase versionchanged
b8b3a1d
vstinner merged commit 2914bb3 into python:master Jan 29, 2018

bedevere-bot commented Jan 29, 2018

Copy link
Copy Markdown

@vstinner: Please replace # with GH- in the commit message next time. Thanks!

vstinner deleted the gil_created branch January 29, 2018 10:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pitrou pitrou left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL