Repository navigation
bpo-26133: Fix typos - #5010
Merged
asvetlov merged 3 commits intoDec 26, 2017
Merged
bpo-26133: Fix typos#5010asvetlov merged 3 commits into
asvetlov merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
1st1
reviewed
Dec 25, 2017
Comment thread
Lib/asyncio/unix_events.py
Outdated
| warnings.warn(f"Closing the loop {self!r} " | ||
| f"on interpreter shutdown " | ||
| f"stage, signal unsubsription is disabled", | ||
| f"stage, signal unsubscription is disabled", |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
unsubscription -> skipping signal handlers removal
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Fixed. Is now ok?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Maybe mock sys.is_finalizing and test that branch of code? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 26, 2017
* Fix typos * Change warning text * Add test (cherry picked from commit a8f4e15)
Copy link
Copy Markdown
|
GH-5014 is a backport of this pull request to the 3.6 branch. |
Sorry, something went wrong.
asvetlov
pushed a commit
that referenced
this pull request
Dec 26, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #5002
https://bugs.python.org/issue26133