FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-32473: Improve ABCMeta._dump_registry() readability by DevOpsCraftsman · Pull Request #5091 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-32473: Improve ABCMeta._dump_registry() readability - #5091

Merged
methane merged 5 commits into
python:masterfrom
DevOpsCraftsman:fix-issue-32473
Jan 12, 2018
ConversationCommits (5)ChecksFiles changed
Merged

bpo-32473: Improve ABCMeta._dump_registry() readability#5091
methane merged 5 commits into
python:masterfrom
DevOpsCraftsman:fix-issue-32473

Conversation

DevOpsCraftsman commented Jan 3, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown

methane commented Jan 10, 2018

Copy link
Copy Markdown
Member

would you add news entry?

DevOpsCraftsman commented Jan 10, 2018

Copy link
Copy Markdown
Author

Done!

methane requested changes Jan 11, 2018
View reviewed changes
Comment thread Lib/abc.py Outdated
@@ -173,6 +173,8 @@ def _dump_registry(cls, file=None):
for name in sorted(cls.__dict__.keys()):

methane Jan 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

sorted() is not needed anymore because dict order is stable.

Other option is whitelist members ('_abc_registry', '_abc_cache', '_abc_negative_cache', '_abc_negative_cache_version').

DevOpsCraftsman Jan 11, 2018

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would prefer the whitelist: a suitable order increase also readability...
But I think to stick with if name.startswith("_abc_") is easier to maintain.
I was told that this will be rewritten in C, so it's not a big deal.

bedevere-bot commented Jan 11, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

DevOpsCraftsman commented Jan 11, 2018

Copy link
Copy Markdown
Author

I have made the requested changes; please review again

bedevere-bot commented Jan 11, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@methane: please review the changes made to this pull request.

methane changed the title bpo-32473 Improve ABCMeta._dump_registry() readability bpo-32473: Improve ABCMeta._dump_registry() readability Jan 12, 2018
methane merged commit ae12f5d into python:master Jan 12, 2018

methane commented Jan 12, 2018

Copy link
Copy Markdown
Member

thanks

methane commented Jan 12, 2018

Copy link
Copy Markdown
Member

Hm, I think this is safe enough to backport to 3.6.

miss-islington commented Jan 12, 2018

Copy link
Copy Markdown
Contributor

Thanks @yahya-abou-imran for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

bedevere-bot commented Jan 12, 2018

Copy link
Copy Markdown

GH-5163 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 12, 2018
bpo-32473: Improve ABCMeta._dump_registry() readability (pythonGH-5091)
810a40c 
(cherry picked from commit ae12f5d)
methane pushed a commit that referenced this pull request Jan 12, 2018
bpo-32473: Improve ABCMeta._dump_registry() readability (GH-5091)
a91662a 
(cherry picked from commit ae12f5d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

methane methane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL