FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix in docs: import auto in enum chapter by JulianKahnert · Pull Request #5136 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

fix in docs: import auto in enum chapter - #5136

Closed
JulianKahnert wants to merge 1 commit into
python:masterfrom
JulianKahnert:patch-1
ConversationCommits (1)ChecksFiles changed
Closed

fix in docs: import auto in enum chapter#5136
JulianKahnert wants to merge 1 commit into
python:masterfrom
JulianKahnert:patch-1

Conversation

JulianKahnert commented Jan 8, 2018

Copy link
Copy Markdown
Contributor

No description provided.

the-knights-who-say-ni commented Jan 8, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

JulianKahnert commented Jan 11, 2018

Copy link
Copy Markdown
Contributor Author

CLA should be signed now

Mariatta requested changes Jan 12, 2018
View reviewed changes

Mariatta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The change is good, but please make sure Travis CI passes. I couldn't view the log. My guess is maybe there's trailing whitespace.
Also, the [3.6] should be removed from PR title.
This change is targeting the master branch. [3.6] in PR title are meant for PRs targeting the 3.6 branch. Thanks.

bedevere-bot commented Jan 12, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

JulianKahnert changed the title [3.6] fix in docs: import auto in enum chapter fix in docs: import auto in enum chapter Jan 12, 2018

JulianKahnert commented Jan 12, 2018

Copy link
Copy Markdown
Contributor Author

TravisCI failed because of a github timeout error ... try to trigger the build process again.

JulianKahnert mentioned this pull request Jan 12, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Mariatta Mariatta requested changes

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL