FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Implement the get_resource_reader() API for file system imports by warsaw · Pull Request #5168 · python/cpython · GitHub

/ cpython Public

Implement the get_resource_reader() API for file system imports - #5168

Merged
warsaw merged 10 commits into
python:masterfrom
warsaw:resource-reader
Jan 15, 2018
ConversationCommits (10)ChecksFiles changed
Merged

Implement the get_resource_reader() API for file system imports#5168
warsaw merged 10 commits into
python:masterfrom
warsaw:resource-reader

Conversation

warsaw commented Jan 12, 2018

Copy link
Copy Markdown
Member

No description provided.

warsaw commented Jan 12, 2018

Copy link
Copy Markdown
Member Author

@brettcannon I've moved the zipimport work to a separate branch, still in progress.

brettcannon self-requested a review January 12, 2018 20:33
brettcannon requested changes Jan 12, 2018
View reviewed changes

brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks great overall, but we do need docs for this.

bedevere-bot commented Jan 12, 2018

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

warsaw commented Jan 13, 2018

Copy link
Copy Markdown
Member Author

@brettcannon Didn't you just land the docs for this in bca4218 ?

warsaw commented Jan 13, 2018

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

python deleted a comment from bedevere-bot Jan 13, 2018

warsaw commented Jan 15, 2018

Copy link
Copy Markdown
Member Author

@brettcannon Ping. I'm rebasing my zipimporter branch on top of this one, so I'd like to land it soon. See my previous comment about the docs.

brettcannon commented Jan 15, 2018

Copy link
Copy Markdown
Member

I landed the docs for the ABC, but I didn't document anything relating to the changes in this PR. I've gone ahead and approved this so you can get your zipimporter changes in as we can do doc changes in after b1 if necessary.

warsaw merged commit 5ec0fee into python:master Jan 15, 2018
warsaw deleted the resource-reader branch January 16, 2018 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL