FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-32549: Compile OpenSSL 1.1.0 on Travis CI by tiran · Pull Request #5180 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-32549: Compile OpenSSL 1.1.0 on Travis CI - #5180

Merged
tiran merged 1 commit into
python:masterfrom
tiran:travis_openssl
Jan 16, 2018
ConversationCommits (1)ChecksFiles changed
Merged

bpo-32549: Compile OpenSSL 1.1.0 on Travis CI#5180
tiran merged 1 commit into
python:masterfrom
tiran:travis_openssl

Conversation

tiran commented Jan 14, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

Use an improved version of multissl test helper to compile a local copy
of OpenSSL 1.1.0g.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue32549

tiran force-pushed the travis_openssl branch 2 times, most recently from 31cac11 to 0857d9c Compare January 14, 2018 10:42
tiran changed the title Compile OpenSSL 1.1.0 for Travis CI bpo-32549: Compile OpenSSL 1.1.0 on Travis CI Jan 14, 2018
tiran force-pushed the travis_openssl branch 2 times, most recently from 1a2dc69 to 88ae122 Compare January 14, 2018 10:51
bpo-32549: Compile OpenSSL 1.1.0 on Travis CI
b35b7ff 
Use an improved version of multissl test helper to compile a local copy
of OpenSSL 1.1.0g.

Signed-off-by: Christian Heimes <christian@python.org>
tiran requested review from brettcannon and vstinner January 16, 2018 15:36

tiran commented Jan 16, 2018

Copy link
Copy Markdown
Member Author

@brettcannon @vstinner

This PR is a prerequisite for several of my ssl improvements. Do you agree with my approach? I'm going to remove the hak ss soon as Travis has OpenSSL 1.0.2+ in a base image.

Also see travis-ci/travis-ci#9069

tiran mentioned this pull request Jan 16, 2018
Merged
brettcannon approved these changes Jan 16, 2018
View reviewed changes

brettcannon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM; whatever works to unblock you is basically fine by me. 😄

tiran commented Jan 16, 2018

Copy link
Copy Markdown
Member Author

@brettcannon thanks! I'm also changing travis CI settings from monthly to daily cron job on master. This will populate the cache tonight. Further runs should reuse pre-cached openssl builds.

tiran merged commit ced9cb5 into python:master Jan 16, 2018
tiran deleted the travis_openssl branch January 16, 2018 20:02

tiran commented Jan 16, 2018

Copy link
Copy Markdown
Member Author

s/change/add/g

We didn't have cronjob runs at all. I misunderstood the UI.

pitrou reviewed Jan 16, 2018
View reviewed changes
Comment thread .travis.yml
exit
fi
if [ "${TESTING}" != "docs" ]; then
# clang complains about unused-parameter a lot, redirect stderr

pitrou Jan 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

At some point, perhaps the before_script should be factored out instead of duplicating all its contents?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pitrou pitrou left review comments
brettcannon brettcannon approved these changes
vstinner Awaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL