FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-32651 Recommend getpass.getuser() by warsaw · Pull Request #5301 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-32651 Recommend getpass.getuser() - #5301

Merged
warsaw merged 4 commits into
python:masterfrom
warsaw:issue32651
Jan 24, 2018
ConversationCommits (4)ChecksFiles changed
Merged

bpo-32651 Recommend getpass.getuser()#5301
warsaw merged 4 commits into
python:masterfrom
warsaw:issue32651

Conversation

warsaw commented Jan 24, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

berkerpeksag approved these changes Jan 24, 2018
View reviewed changes

berkerpeksag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Since this is a small documentation improvement, a NEWS entry is not needed. If you still want to add it, I just left a comment :)

Do you plan to backport this to the 3.6 branch? I think it would be nice to get this into the 3.6 branch.

Comment thread Misc/NEWS.d/next/Documentation/2018-01-24-10-42-57.bpo-32651.a_tZhY.rst Outdated
@@ -0,0 +1,2 @@
In the :func:`os.getlogin()` documentation, recommend
func:`getpass.getuser()`.

berkerpeksag Jan 24, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Missing ':' here. And use of parenthesis is not needed.

warsaw self-assigned this Jan 24, 2018

warsaw commented Jan 24, 2018

Copy link
Copy Markdown
Member Author

@berkerpeksag Yeah, I guess that's true. I've added the tag and will remove the file.

warsaw commented Jan 24, 2018

Copy link
Copy Markdown
Member Author

I do plan on back porting this too, so I've added that label.

warsaw merged commit d499031 into python:master Jan 24, 2018

miss-islington commented Jan 24, 2018

Copy link
Copy Markdown
Contributor

Thanks @warsaw for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 24, 2018
bpo-32651 Recommend getpass.getuser() (pythonGH-5301)
1bf26da 
* bpo-32651 - In the documentation for os.getlogin(), recommend getpass.getuser()
(cherry picked from commit d499031)

bedevere-bot commented Jan 24, 2018

Copy link
Copy Markdown

GH-5304 is a backport of this pull request to the 3.6 branch.

warsaw deleted the issue32651 branch January 24, 2018 17:54
warsaw pushed a commit that referenced this pull request Jan 24, 2018
bpo-32651 Recommend getpass.getuser() (GH-5301) (#5304)
196b8cb 
* bpo-32651 - In the documentation for os.getlogin(), recommend getpass.getuser()
(cherry picked from commit d499031)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

berkerpeksag berkerpeksag approved these changes

Assignees

warsaw

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL