Repository navigation
bpo-32690: Preserve order of locals() - #5379
Merged
rhettinger merged 2 commits intoJan 28, 2018
Merged
rhettinger merged 2 commits into
rhettinger merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@rhettinger The code change looks good to me, but are you sure we want to skip the NEWS entry? Otherwise folks may be puzzled as to why the behaviour is different in 3.6.4 and earlier. |
Sorry, something went wrong.
Copy link
Copy Markdown
|
@rhettinger: Please replace # with GH- in the commit message next time. Thanks! |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Thanks @rhettinger for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
Sorry, something went wrong.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 28, 2018
(cherry picked from commit a4d0001)
Copy link
Copy Markdown
|
GH-5390 is a backport of this pull request to the 3.6 branch. |
Sorry, something went wrong.
rhettinger
pushed a commit
that referenced
this pull request
Jan 28, 2018
ncoghlan
added a commit
to ncoghlan/cpython
that referenced
this pull request
Jan 30, 2018
…ython#5390)" This reverts commit 9105879 in order to keep the behaviour of locals() consistent between 3.6.4 and 3.6.5+.
ncoghlan
added a commit
that referenced
this pull request
Jan 30, 2018
This reverts commit 9105879 in order to keep the behaviour of locals() consistent between 3.6.4 and 3.6.5+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32690