FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-20104: Fix memory leaks and error handling in posix spawn by pablogsal · Pull Request #5418 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-20104: Fix memory leaks and error handling in posix spawn #5418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 9 commits into from
Jan 29, 2018
Conversation 22 Commits 9 Checks 0 Files changed
Merged

bpo-20104: Fix memory leaks and error handling in posix spawn #5418

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
84de22c
Fix memory leaks and error handling in posix spawn
pablogsal Jan 29, 2018
5d8264c
Improve error handling when destroying the file_actions object
pablogsal Jan 29, 2018
06444fd
Py_DECREF the result of PySequence_Fast on error
pablogsal Jan 29, 2018
3c2c4e8
Handle uninitialized pid
pablogsal Jan 29, 2018
57b6303
Use OSError if file actions fails to initialize
pablogsal Jan 29, 2018
78ea6d5
Move _file_actions to outer scope to avoid undefined behaviour
pablogsal Jan 29, 2018
a1245a2
Remove HAVE_POSIX_SPAWN define in Modules/posixmodule.c
pablogsal Jan 29, 2018
1b75f89
Unshadow exception and clean error message
pablogsal Jan 29, 2018
4e9e54e
Fix whitespace issues
pablogsal Jan 29, 2018
File filter

Filter by extension

Filter by extension .c  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
Prev Previous commit
Fix whitespace issues
  • Loading branch information
pablogsal committed Jan 29, 2018
commit 4e9e54e0d7043fa53b041e398f7d574ab611638d
2 changes: 1 addition & 1 deletion Modules/posixmodule.c
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -5294,7 +5294,7 @@ os_posix_spawn_impl(PyObject *module, path_t *path, PyObject *argv,
Py_XDECREF(seq);

if(file_actionsp) {
posix_spawn_file_actions_destroy(file_actionsp);
posix_spawn_file_actions_destroy(file_actionsp);
}

if (envlist) {
Expand Down
Back | FazBrowse Home | New Git URL