FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-10381, bpo-32403: What's new entries for changes to datetime by pganssle · Pull Request #5814 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-10381, bpo-32403: What's new entries for changes to datetime - #5814

Merged
abalkin merged 2 commits into
python:masterfrom
pganssle:datetime-whatsnew
Feb 27, 2018
ConversationCommits (2)ChecksFiles changed
Merged

bpo-10381, bpo-32403: What's new entries for changes to datetime#5814
abalkin merged 2 commits into
python:masterfrom
pganssle:datetime-whatsnew

Conversation

pganssle commented Feb 22, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This adds "What's New" entries for two datetime-related improvements I made in #4993 (bpo-32403) and #5032 (bpo-10381).

For the "optimizations" one, I was not sure how best to measure the improvement in speed but I just put "significant". My initial benchmarks suggest that some of the constructors have as much as 100% speed improvement, but none of that was done against an optimized build.

https://bugs.python.org/issue10381

abalkin commented Feb 22, 2018

Copy link
Copy Markdown
Member

@ned-deily - I am not sure what the procedure is for adding What's New in 3.7 entries. Please advise.

The text LGTM.

ned-deily commented Feb 22, 2018

Copy link
Copy Markdown
Member

@abalkin After merging to the master branch, you should only need to backport to 3.7 like any other change and that should happen automatically.

pganssle commented Feb 22, 2018

Copy link
Copy Markdown
Member Author

Should I try to do some sort of benchmarking before this is merged to give an estimate of the order of magnitude of the speedup?

ned-deily commented Feb 22, 2018

Copy link
Copy Markdown
Member

@pganssle As far as I'm concerned, "significant" is sufficient. Thanks for doing this.

abalkin closed this Feb 27, 2018
abalkin reopened this Feb 27, 2018
abalkin merged commit 5bd04f9 into python:master Feb 27, 2018

miss-islington commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

Thanks @pganssle for the PR, and @abalkin for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2018
bpo-10381, bpo-32403: What's new entries for changes to datetime (pyt…
c02c8bb 
…hongh-5814)

* Add What's New entry for addition of datetime.timezone to the C API

Closes bpo-10381

* Add what's new entry for date and datetime optimizations

Closes bpo-32403
(cherry picked from commit 5bd04f9)

Co-authored-by: Paul Ganssle <pganssle@users.noreply.github.com>

bedevere-bot commented Feb 27, 2018

Copy link
Copy Markdown

GH-5929 is a backport of this pull request to the 3.7 branch.

abalkin pushed a commit that referenced this pull request Feb 27, 2018
bpo-10381, bpo-32403: What's new entries for changes to datetime (gh-…
fff596f 
…5814) (gh-5929)

* Add What's New entry for addition of datetime.timezone to the C API

Closes bpo-10381

* Add what's new entry for date and datetime optimizations

Closes bpo-32403
(cherry picked from commit 5bd04f9)

Co-authored-by: Paul Ganssle <pganssle@users.noreply.github.com>
pganssle deleted the datetime-whatsnew branch October 25, 2018 14:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL