Repository navigation
fix typo - #59
Conversation
Sorry, something went wrong.
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
Sorry, something went wrong.
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 82.37% 82.37% -0.01%
==========================================
Files 1427 1427
Lines 350948 350948
==========================================
- Hits 289102 289084 -18
- Misses 61846 61864 +18Continue to review full report at Codecov.
|
Sorry, something went wrong.
methane
left a comment
There was a problem hiding this comment.
Thank you for fix typos.
But two typos are from upstream project. Please fix them at upstream.
Remained three fixes are LGTM
Sorry, something went wrong.
| dnl | ||
| dnl Please remember that m4 expands AC_REQUIRE([PKG_PROG_PKG_CONFIG]) | ||
| dnl only at the first occurence in configure.ac, so if the first place | ||
| dnl only at the first occurrence in configure.ac, so if the first place |
There was a problem hiding this comment.
This file is generated. Don't change this file.
This typo comes from pkg.m4 in pkg-config. Please fix it in upstream.
Sorry, something went wrong.
| * deflate_stored() is written to minimize the number of times an input byte is | ||
| * copied. It is most efficient with large input and output buffers, which | ||
| * maximizes the opportunites to have a single copy from next_in to next_out. | ||
| * maximizes the opportunities to have a single copy from next_in to next_out. |
There was a problem hiding this comment.
This file is bundled. Please report the typo to zlib.
Sorry, something went wrong.
Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Move bytecode_offset=-1 initialization into hir_c_alloc_instr so the invariant is structurally enforced — even if hir_c_init_instr is accidentally skipped, bytecode_offset will be -1 (not 0 from calloc). Add runtime regression test in hir_instr_c_verify.cpp that verifies the invariant for all three allocation paths (raw alloc, init_instr, init_deopt). Runs at startup via __attribute__((constructor)). Addresses gap flagged 5 times (Pythia python#14, python#40, python#59, librarian x2).
fix typo