FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "bpo-31961: subprocess now accepts path-like args (GH-4329)" by serhiy-storchaka · Pull Request #5912 · python/cpython · GitHub

/ cpython Public

Revert "bpo-31961: subprocess now accepts path-like args (GH-4329)" - #5912

Merged
ned-deily merged 2 commits into
python:masterfrom
serhiy-storchaka:revert-31961
Feb 27, 2018
ConversationCommits (2)ChecksFiles changed
Merged

Revert "bpo-31961: subprocess now accepts path-like args (GH-4329)"#5912
ned-deily merged 2 commits into
python:masterfrom
serhiy-storchaka:revert-31961

Conversation

serhiy-storchaka commented Feb 26, 2018 •
edited
Loading

Copy link
Copy Markdown
Member

This reverts commit dd42cb7 and commit 5537646.

https://bugs.python.org/issue31961

gpshead reviewed Feb 26, 2018
View reviewed changes
Comment thread Lib/test/test_subprocess.py Outdated

gpshead Feb 26, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do not revert 5537646. It should be a bugfix no matter what. cmd is a list and comes through the repr into this python code string as a list. using [cmd] would make it a list of lists which is never desirable here.

gpshead commented Feb 26, 2018

Copy link
Copy Markdown
Member

We do need a Misc/NEWS entry - either adding one saying the previous change was undone, or removing the Misc/NEWS entry that was added for the original change. I've asked Ned on the bug which way we should go with that.

ned-deily commented Feb 27, 2018

Copy link
Copy Markdown
Member

Is this ready to go?

serhiy-storchaka commented Feb 27, 2018

Copy link
Copy Markdown
Member Author

Only if we will decide to revert this feature completely. If we will decide to keep it see the bugfix PR #5914.

ned-deily commented Feb 27, 2018

Copy link
Copy Markdown
Member

I'll give @gpshead a few hours to chime in since it is early in the day for him.

ned-deily commented Feb 27, 2018

Copy link
Copy Markdown
Member

The clock has run out for 3.7.0b2. I'm going to push this and backport it to 3.7. We can decide later what to do for both 3.8 and 3.7.

ned-deily merged commit be50a7b into python:master Feb 27, 2018

bedevere-bot commented Feb 27, 2018

Copy link
Copy Markdown

@ned-deily: Please replace # with GH- in the commit message next time. Thanks!

miss-islington commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2018
Revert "bpo-31961: subprocess now accepts path-like args (pythonGH-4329…
d6ce482 
…)" (pythonGH-5912)

* Revert "bpo-31961: subprocess now accepts path-like args (pythonGH-4329)"

This reverts commit dd42cb7.
(cherry picked from commit be50a7b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
ned-deily pushed a commit that referenced this pull request Feb 27, 2018
Revert "bpo-31961: subprocess now accepts path-like args (GH-4329)" (G…
b7dcae3 
…H-5912) (GH-5931)

* Revert "bpo-31961: subprocess now accepts path-like args (GH-4329)"

This reverts commit dd42cb7.
(cherry picked from commit be50a7b)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 28, 2018
Revert "Revert "bpo-31961: subprocess now accepts path-like args (pyt…
0b4e876 
…honGH-4329)" (python#5912)"

This reverts commit be50a7b.

bedevere-bot commented Mar 18, 2018

Copy link
Copy Markdown

GH-5931 is a backport of this pull request to the 3.7 branch.

serhiy-storchaka deleted the revert-31961 branch October 30, 2018 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead left review comments

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL