FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-29534: _decimal difference with _pydecimal by andrewnester · Pull Request #65 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-29534: _decimal difference with _pydecimal - #65

Merged
mdickinson merged 1 commit into
python:masterfrom
andrewnester:29534-decimal
Feb 14, 2017
ConversationCommits (1)ChecksFiles changed
Merged

bpo-29534: _decimal difference with _pydecimal#65
mdickinson merged 1 commit into
python:masterfrom
andrewnester:29534-decimal

Conversation

andrewnester commented Feb 13, 2017

Copy link
Copy Markdown
Contributor

the-knights-who-say-ni commented Feb 13, 2017

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement
  4. If you just signed the CLA, please wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

berkerpeksag changed the title Fixed #29534 - _decimal difference with _pydecimal bpo-29534: _decimal difference with _pydecimal Feb 13, 2017
berkerpeksag requested a review from skrah February 13, 2017 10:27

mdickinson commented Feb 13, 2017

Copy link
Copy Markdown
Member

The new behaviour seems like the right thing to me. Can you rework the code to avoid the repetition of the if cls is Decimal block?

andrewnester commented Feb 13, 2017

Copy link
Copy Markdown
Contributor Author

@mdickinson thanks for the comment! I've just reworked my PR to avoid code duplication.

mdickinson reviewed Feb 13, 2017
View reviewed changes

mdickinson left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Changes mostly LGTM, modulo a couple of nitpicks.

Still needs:

  • contributor agreement for Andrew
  • Misc/NEWS entry

Comment thread Lib/_pydecimal.py Outdated

mdickinson Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Style nit: please add a space after the >=.

Comment thread Lib/test/test_decimal.py Outdated

mdickinson Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This change seems unrelated to the PR; please could you revert it?

Comment thread Lib/test/test_decimal.py Outdated

mdickinson Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is just nitpicking, but I think we're testing the wrong thing here: the change is in the type of the object that's passed to the Decimal subclass; the repr of the value was just a convenient way of demonstrating the difference in behaviours between the Python and C decimal implementations. How about recording and checking the type instead of the repr?

andrewnester Feb 13, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@mdickinson good idea, thanks!

andrewnester commented Feb 13, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@mdickinson thanks! I've fixed all the nitpickings you mentioned. Also updated NEWS.

mdickinson commented Feb 13, 2017

Copy link
Copy Markdown
Member

@andrewnester: Thank you! One last nitpick: please could you change the name of the test?

Apart from that, this looks good to go. Did you fill out the CLA?

andrewnester commented Feb 13, 2017

Copy link
Copy Markdown
Contributor Author

@mdickinson fixed. yes, I filled it couple of hours ago :)

mdickinson commented Feb 13, 2017

Copy link
Copy Markdown
Member

In, that case, LGTM unconditionally.

mdickinson approved these changes Feb 13, 2017
View reviewed changes

mdickinson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

codecov Bot commented Feb 13, 2017

Copy link
Copy Markdown

Codecov Report

Merging #65 into master will decrease coverage by -0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   82.37%   82.37%   -0.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350959      +11     
==========================================
+ Hits       289095   289100       +5     
- Misses      61853    61859       +6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cdbd68...c030ca7. Read the comment docs.

mdickinson commented Feb 13, 2017

Copy link
Copy Markdown
Member

The coverage gods seem a bit peeved, but I can't make head or tail of the coverage report. Which 6 lines are new misses? (And which 5 lines are new hits?)

mdickinson merged commit 6d1dece into python:master Feb 14, 2017

mdickinson commented Feb 14, 2017

Copy link
Copy Markdown
Member

Merged. Thanks for the contribution!

mdickinson mentioned this pull request Feb 14, 2017
Merged
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Update aiohttp from 3.0.1 to 3.0.2 (GH-65)
19b429b
sunmy2019 referenced this pull request in sunmy2019/cpython Apr 9, 2023
Merge pull request #65 from lysnikolaou/more-fstring-errors
9a6e7e4
oraluben pushed a commit to oraluben/cpython that referenced this pull request Jul 14, 2023
feat: execute jitted code in BB_BRANCH (python#65)
4768ece 
* refactor: return BB metadata from BB creation function

* feat: add execute jitted code in BB_BRANCH

* nit: disable JIT debug

* nit: Removed debugging comment in ceval_macros.h

* nit: Removed indirection warning in jit.py

---------

Co-authored-by: Jules <julia.poo.poo.poo@gmail.com>
gvanrossum mentioned this pull request Aug 22, 2023
Closed
LinanV mentioned this pull request Oct 23, 2023
Closed
crazymerlyn mentioned this pull request Sep 22, 2024
Merged
ngoldbaum mentioned this pull request Sep 23, 2024
Closed
This was referenced Feb 11, 2025
Closed
Closed
AA-Turner pushed a commit to AA-Turner/cpython that referenced this pull request Apr 17, 2025
Remove interpolation_compare() and interpolation_hash() (python#65)
99c3bf4
sergey-miryanov mentioned this pull request Dec 18, 2025
Closed
ngoldbaum mentioned this pull request Mar 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
mdickinson mdickinson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL