FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33348: parse expressions after * and ** in lib2to3 by zsol · Pull Request #6586 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-33348: parse expressions after * and ** in lib2to3 - #6586

Merged
miss-islington merged 3 commits into
python:masterfrom
zsol:2to3-star-expressions
Oct 24, 2019
ConversationCommits (3)ChecksFiles changed
Merged

bpo-33348: parse expressions after * and ** in lib2to3#6586
miss-islington merged 3 commits into
python:masterfrom
zsol:2to3-star-expressions

Conversation

zsol commented Apr 24, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

These are valid even in python 2.7

https://bugs.python.org/issue33348

Automerge-Triggered-By: @gpshead

tirkarthi mentioned this pull request Apr 24, 2019
Closed

thatch commented Jun 19, 2019

Copy link
Copy Markdown
Contributor

Ping for review... @pablogsal ?

zsol mentioned this pull request Jun 19, 2019
Open

lybroman commented Jul 5, 2019

Copy link
Copy Markdown

Any update on this issue?

gpshead self-assigned this Oct 24, 2019

gpshead commented Oct 24, 2019

Copy link
Copy Markdown
Member

closing and opening to re-trigger CI testing.

gpshead closed this Oct 24, 2019
gpshead reopened this Oct 24, 2019
gpshead mentioned this pull request Oct 24, 2019
Merged

miss-islington commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

@zsol: Status check is done, and it's a success ✅ .

miss-islington merged commit 96b06ae into python:master Oct 24, 2019

miss-islington commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

Thanks @zsol for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot commented Oct 24, 2019

Copy link
Copy Markdown

GH-16913 is a backport of this pull request to the 3.8 branch.

bedevere-bot commented Oct 24, 2019

Copy link
Copy Markdown

GH-16914 is a backport of this pull request to the 3.7 branch.

miss-islington commented Oct 24, 2019

Copy link
Copy Markdown
Contributor

Sorry, @zsol, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 96b06aefe23521b61e4e9cdd44f5d30b00c7eb95 2.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2019
bpo-33348: parse expressions after * and ** in lib2to3 (pythonGH-6586)
1364e5d 
These are valid even in python 2.7

https://bugs.python.org/issue33348

Automerge-Triggered-By: @gpshead
(cherry picked from commit 96b06ae)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>

gpshead commented Oct 24, 2019

Copy link
Copy Markdown
Member

If anyone wants to see this in lib2to3 included with the final 2.7.18 release of 2.7, they'l need to do the backport PR work. I suggest not worrying about it. :)

miss-islington added a commit that referenced this pull request Oct 24, 2019
bpo-33348: parse expressions after * and ** in lib2to3 (GH-6586)
0160a70 
These are valid even in python 2.7

https://bugs.python.org/issue33348

Automerge-Triggered-By: @gpshead
(cherry picked from commit 96b06ae)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
miss-islington added a commit that referenced this pull request Oct 24, 2019
bpo-33348: parse expressions after * and ** in lib2to3 (GH-6586)
d04661f 
These are valid even in python 2.7

https://bugs.python.org/issue33348

Automerge-Triggered-By: @gpshead
(cherry picked from commit 96b06ae)

Co-authored-by: Zsolt Dollenstein <zsol.zsol@gmail.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019
bpo-33348: parse expressions after * and ** in lib2to3 (pythonGH-6586)
a51eed2 
These are valid even in python 2.7


https://bugs.python.org/issue33348



Automerge-Triggered-By: @gpshead
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020
bpo-33348: parse expressions after * and ** in lib2to3 (pythonGH-6586)
fb78979 
These are valid even in python 2.7


https://bugs.python.org/issue33348



Automerge-Triggered-By: @gpshead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

gpshead gpshead approved these changes

Assignees

miss-islington

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL