FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-20104: Change the file_actions parameter of os.posix_spawn(). by serhiy-storchaka · Pull Request #6725 · python/cpython · GitHub

Repository navigation

bpo-20104: Change the file_actions parameter of os.posix_spawn(). - #6725

Merged
serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:posix_spawn-file_actions
Sep 8, 2018
Merged

serhiy-storchaka merged 2 commits into
python:masterfrom
serhiy-storchaka:posix_spawn-file_actions

Conversation

serhiy-storchaka commented May 8, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • Make its default value an empty tuple instead of None.
  • Make it a keyword-only parameter.

https://bugs.python.org/issue20104

pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM Do you want to wait until #6693 is merged to land this or you prefer to do it before?

serhiy-storchaka commented Jul 29, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

It doesn't matter what PR will be merged first. But I want to wait for a review from any of other involved core devs: @benjaminp or @gpshead.

* Make its default value an empty tuple instead of None.
* Make it a keyword-only parameter.
serhiy-storchaka merged commit d700f97 into python:master Sep 8, 2018
serhiy-storchaka deleted the posix_spawn-file_actions branch September 8, 2018 11:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news type-feature A feature request or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL