Repository navigation
bpo-33351: Correct struct packing in _tracemalloc.c - #6761
Closed
emmatyping wants to merge 3 commits into
Closed
emmatyping wants to merge 3 commits into
emmatyping wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@zooba this is the issue I mentioned earlier. I'd appreciate your review! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first of several patches to add clang-cl compatibility to CPython. (Expect more in the coming days).
While it seems MSVC accepts pragma pack/push after the struct tag, clang-cl does not. AFAIK, pragma pack/push usually should go before the tag. This also adds the same packing to pointer_t (which was packed on GCC but not MSVC) and fixed the comment for pointer_t.
Also, I wasn't sure if a news entry was needed since this is a small internal patch and I couldn't find guidelines for when a news entry should be provided.
https://bugs.python.org/issue33351