FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33440: Defer imports in pathlib to reduce its import time. by agfor · Pull Request #6820 · python/cpython · GitHub

/ cpython Public

bpo-33440: Defer imports in pathlib to reduce its import time. - #6820

Closed
agfor wants to merge 2 commits into
python:mainfrom
agfor:pathlib_defer_imports
ConversationCommits (2)ChecksFiles changed
Closed

bpo-33440: Defer imports in pathlib to reduce its import time.#6820
agfor wants to merge 2 commits into
python:mainfrom
agfor:pathlib_defer_imports

Conversation

agfor commented May 14, 2018 •
edited
Loading

Copy link
Copy Markdown

serhiy-storchaka reviewed May 14, 2018
View reviewed changes
Comment thread Lib/pathlib.py Outdated

def make_uri(self, path):
# Under Windows, file URIs use the UTF-8 encoding.
from urllib.parse import quote_from_bytes as urlquote_from_bytes

serhiy-storchaka May 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What is the reason of the renaming?

matrixise May 14, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

there is no reason, you are right but this is just a copy. Now he could remove the renaming.

matrixise commented May 14, 2018

Copy link
Copy Markdown
Member

@serhiy-storchaka I can't merge this PR, if you want to merge it, let's go! ;-)

serhiy-storchaka commented May 14, 2018

Copy link
Copy Markdown
Member

I don't know whether this change is worth merging.

serhiy-storchaka requested a review from pitrou May 14, 2018 19:52

matrixise commented May 14, 2018

Copy link
Copy Markdown
Member

ok thanks for your feedback @serhiy-storchaka

csabella requested a review from ncoghlan May 22, 2019 10:19
csabella requested review from ncoghlan and pitrou and removed request for ncoghlan and pitrou February 7, 2020 11:28
pitrou requested changes Feb 7, 2020
View reviewed changes

pitrou left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, it looks like this review took a long delay for a simple change. This looks good to me on the principle but you need to do two things:

  • merge / rebase your changes on git master
  • add a NEWS entry for the change (you can use blurb-it or blurb)

Also, would be nice if you posted import benchmark numbers for the change.

bedevere-bot commented Feb 7, 2020

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

csabella commented Jun 12, 2020

Copy link
Copy Markdown
Contributor

@agfor, please take a look at the review comments from pitrou. Thanks!

AlexWaygood added the performance Performance or resource usage label Apr 11, 2022

AlexWaygood commented Apr 11, 2022

Copy link
Copy Markdown
Member

I'm closing this PR, since it has been 2 years and @pitrou's review comments have still not been addressed.

@agfor: if you're still interested in working on this issue, please feel free to continue discussing it at #77621 and/or submit a new PR 🙂

ncoghlan mentioned this pull request Jun 21, 2022
Closed
iritkatriel added 3.12 only security fixes and removed 3.12 only security fixes labels Sep 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments
pitrou pitrou requested changes
matrixise matrixise approved these changes
ncoghlan Awaiting requested review from ncoghlan

Assignees

No one assigned

Labels

awaiting changes performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL