Repository navigation
bpo-1025395: Fix email.utils.parseaddr to handle multiple hops - #6917
ioanatia wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
@bitdancer any chance of a review of this? |
Sorry, something went wrong.
|
@warsaw or @bitdancer Will one of you be able to review this please? Thanks. |
Sorry, something went wrong.
maxking
left a comment
There was a problem hiding this comment.
Thanks @ioanatia for this fix, not sure why you closed this PR though :)
The patch looks good to me and seems to fix the bug, I have suggested a slight modification to the NEWS entry.
Sorry, something went wrong.
| @@ -0,0 +1 @@ | |||
| Fix email.utils.parseaddr to handle multiple hops | |||
There was a problem hiding this comment.
I'd suggest a slight change to wrap email.utils.parseaddr in double backticks "``" so that it is rendered correctly with code in rst format.
Also, can you can add a full stop at the end of the sentence.
Sorry, something went wrong.
This fixes a very old issue with email.utils.parseaddr.
Right now email.utils.parseaddr will fail to parse the input correctly when the address contains a route with multiple hops. However it does not have an issue with single hop routes.
RFC5322 states that including route hops is obsolete and that the route part should be ignored (Section 4.4). It also states that this syntax is valid and it must be accepted and parsed (Section 4).
https://bugs.python.org/issue1025395
This is a duplicate of #142 , the Travis build failing because of changes unrelated to the PR. I have rebased my old branch on latest master, but that still does not seem to help. 🤔 🐱 . @Mariatta