FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Tweak .codedoc.yml to make it more useful by berkerpeksag · Pull Request #71 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

Tweak .codedoc.yml to make it more useful - #71

Merged
berkerpeksag merged 8 commits into
python:masterfrom
berkerpeksag:tweak-codecov
Feb 14, 2017
ConversationCommits (8)ChecksFiles changed
Merged

Tweak .codedoc.yml to make it more useful#71
berkerpeksag merged 8 commits into
python:masterfrom
berkerpeksag:tweak-codecov

Conversation

berkerpeksag commented Feb 13, 2017

Copy link
Copy Markdown
Member

No description provided.

briancurtin reviewed Feb 13, 2017
View reviewed changes
Comment thread .codecov.yml Outdated
default:
threshold: 0.01
only_pulls: true
paths:

briancurtin Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm guessing this means it only ends up being run for those directories, right? If so, that's good that it avoids being run on, e.g., Doc/* changes, but shouldn't it also run on directories like Objects/?

berkerpeksag Feb 13, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm guessing this means it only ends up being run for those directories, right?

Correct.

[...] but shouldn't it also run on directories like Objects/?

Good point. I'm reading docs again so I hopefully will have an answer :)

berkerpeksag Feb 13, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

According to https://docs.codecov.io/docs/commit-status#section-patch-status, we don't need to add specific directories. It should only look for the changes in PR.

We can also add directories to ignore: https://docs.codecov.io/docs/ignoring-paths

briancurtin reviewed Feb 13, 2017
View reviewed changes

briancurtin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This seems ok from what I understand of the docs (particularly the coverage/status/{changes|project} part), but I'd prefer to leave it to another set of eyes to approve.

brettcannon approved these changes Feb 13, 2017
View reviewed changes
Comment thread .codecov.yml
- "Mac/**/*"
- "PC/**/*"
- "PCbuild/**/*"
- "Tools/**/*"

brettcannon Feb 13, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Probably should add the Grammar directory.

berkerpeksag Feb 13, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good catch, done.

brettcannon commented Feb 13, 2017

Copy link
Copy Markdown
Member

LGTM. If you can pass it through Codecov's verification tool at https://docs.codecov.io/docs/codecov-yaml#section-validate-your-repository-yaml that would be great.

berkerpeksag commented Feb 13, 2017

Copy link
Copy Markdown
Member Author

Thanks for the review!

If you can pass it through Codecov's verification tool at https://docs.codecov.io/docs/codecov-yaml#section-validate-your-repository-yaml that would be great.

$ curl -XPOST --data-binary @.codecov.yml https://codecov.io/validate
Valid!

# Pretty-printed version of the configuration below

brettcannon commented Feb 13, 2017

Copy link
Copy Markdown
Member

Then I say merge it and let python-dev (or -committers; wherever @Haypo emailed) know about the requisite change.

berkerpeksag merged commit 22ba52b into python:master Feb 14, 2017
berkerpeksag deleted the tweak-codecov branch February 14, 2017 09:56
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Update pytest from 3.4.1 to 3.4.2 (GH-71)
569c6ff
gvanrossum mentioned this pull request Aug 22, 2023
Closed
lysnikolaou referenced this pull request in lysnikolaou/cpython Apr 29, 2024
Merge pull request #71 from mgmacias95/pyrepl
fa37b07 
Test pasting with/without paste mode
ngoldbaum mentioned this pull request Sep 23, 2024
Closed
This was referenced Feb 11, 2025
Closed
Closed
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Apr 19, 2025
Add more concatenation tests (python#71)
4c6cb47
1nftf mentioned this pull request Nov 30, 2025
Open
sergey-miryanov mentioned this pull request Dec 18, 2025
Closed
ngoldbaum mentioned this pull request Mar 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

briancurtin briancurtin left review comments
brettcannon brettcannon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL