FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.7] bpo-22087: Fix Policy.get_event_loop() to detect fork (GH-7208) by miss-islington · Pull Request #7215 · python/cpython · GitHub

/ cpython Public

[3.7] bpo-22087: Fix Policy.get_event_loop() to detect fork (GH-7208) - #7215

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-5d97b7b-3.7
May 29, 2018
Merged

[3.7] bpo-22087: Fix Policy.get_event_loop() to detect fork (GH-7208)#7215
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-5d97b7b-3.7

Conversation

miss-islington commented May 29, 2018
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Original patch by Dan O'Reilly.
(cherry picked from commit 5d97b7b)

Co-authored-by: Yury Selivanov yury@magic.io

https://bugs.python.org/issue22087

Original patch by Dan O'Reilly.
(cherry picked from commit 5d97b7b)

Co-authored-by: Yury Selivanov <yury@magic.io>

vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

IHMO it's too late for 3.7.

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue22087 is as old as asyncio and people learnt how to work around the issue. I don't think that there is any kind of urgency to merge this change into 3.7. I would prefer to leave 3.7 unchanged, and test the change in 3.8 instead. It's too late for 3.7, we are very close to the 3.7rc1.

1st1 commented May 29, 2018

Copy link
Copy Markdown
Member

I don't see why it's too late.

is as old as asyncio and people learnt how to work around the issue

This doesn't sound as an actual explanation why this shouldn't be merged. I don't see any technical problem with this patch or how it can possibly break anything.

Copy link
Copy Markdown
Contributor Author

@1st1: Backport status check is done, and it's a success ✅ .

miss-islington merged commit 2a7eb0b into python:3.7 May 29, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

miss-islington deleted the backport-5d97b7b-3.7 branch May 29, 2018 21:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL