FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33860: Prefer "OrderedDict" over "ordered dictionary" by andresdelfino · Pull Request #7535 · python/cpython · GitHub

Repository navigation

bpo-33860: Prefer "OrderedDict" over "ordered dictionary" - #7535

Closed
andresdelfino wants to merge 1 commit into
python:masterfrom
andresdelfino:patch-1
Closed

andresdelfino wants to merge 1 commit into
python:masterfrom
andresdelfino:patch-1

Conversation

andresdelfino commented Jun 8, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Make it clear that the members special attribute of enums is an OrderedDict, now that "ordered dictionaries" can be somewhat confusing with insertion order being preserved by dict.

https://bugs.python.org/issue33860

Copy link
Copy Markdown
Member

Please, open an issue in http://bugs.python.org and reference that issue number in the pull request title. More info about the workflow:

https://devguide.python.org/pullrequest/#submitting

Thanks! :)

andresdelfino changed the title Make it clear that we talk about an OrderedDict bpo-33860: Prefer OrderedDict over ordered dictionary Jun 14, 2018

Copy link
Copy Markdown
Contributor Author

Issue created :) I merged #7538 into this, because the motivation is the same.

andresdelfino changed the title bpo-33860: Prefer OrderedDict over ordered dictionary bpo-33860: Prefer "OrderedDict" over "ordered dictionary" Jun 14, 2018

Copy link
Copy Markdown
Member

This feels like an unnecessary change. The phrase "ordered dictionary" does not always refer to an 'OrderedDict`, and there is more than one way to order a dictionary besides insertion order.

As a side note: it's generally better to have different pull requests for different modules.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL