FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33833: Fix ProactorSocketTransport AssertionError by twisteroidambassador · Pull Request #7632 · python/cpython · GitHub

Repository navigation

bpo-33833: Fix ProactorSocketTransport AssertionError - #7632

Closed
twisteroidambassador wants to merge 3 commits into
python:masterfrom
twisteroidambassador:bpo33833
Closed

twisteroidambassador wants to merge 3 commits into
python:masterfrom
twisteroidambassador:bpo33833

Conversation

twisteroidambassador commented Jun 11, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

1st1 commented Jun 11, 2018

Copy link
Copy Markdown
Member

Can we have a unittest for this?

Copy link
Copy Markdown
Contributor Author

Can we have a unittest for this?

It may require a bit of advanced Mock() magic. The preconditions are somewhat complex, and the exception is raised in a done_callback, so usually it just goes to the log and nowhere else.

1st1 commented Jun 11, 2018

Copy link
Copy Markdown
Member

It may require a bit of advanced Mock() magic. The preconditions are somewhat complex

Yeah, let's not add more complex mock tests. But if it's possible to recreate the preconditions with a functional test it would be enormously helpful.

and the exception is raised in a done_callback, so usually it just goes to the log and nowhere else.

We have assertLogs or something like that :)

Copy link
Copy Markdown
Contributor Author

Now we have a unit test and blurb.

(I am reminded of this joke when writing the test:

Patient: "Doctor, it hurts when I do this."
Doctor: "Don't do that.")

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL