FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33833: Fix ProactorSocketTransport AssertionError (v2) by twisteroidambassador · Pull Request #7893 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-33833: Fix ProactorSocketTransport AssertionError (v2) - #7893

Merged
asvetlov merged 7 commits into
python:masterfrom
twisteroidambassador:bpo33833
Jul 30, 2018
ConversationCommits (7)ChecksFiles changed
Merged

bpo-33833: Fix ProactorSocketTransport AssertionError (v2)#7893
asvetlov merged 7 commits into
python:masterfrom
twisteroidambassador:bpo33833

Conversation

twisteroidambassador commented Jun 24, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

We have a fix, a unit test, and a blurb. Hopefully it's ready for merge.

https://bugs.python.org/issue33833

GoldenOne1 commented Jul 14, 2018

Copy link
Copy Markdown

When this fix will be released?

asvetlov approved these changes Jul 30, 2018
View reviewed changes

asvetlov left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@1st1 would be nice to get your review too

1st1 commented Jul 30, 2018

Copy link
Copy Markdown
Member

I think the fix is OK. BTW, @twisteroidambassador if you're interested in doing proper refactoring (or a rewrite) of Proactor we need help for that :)

asvetlov merged commit 9045199 into python:master Jul 30, 2018

bedevere-bot commented Jul 30, 2018

Copy link
Copy Markdown

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!

miss-islington commented Jul 30, 2018

Copy link
Copy Markdown
Contributor

Thanks @twisteroidambassador for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 30, 2018
bpo-33833: Fix ProactorSocketTransport AssertionError (pythonGH-7893)
e5a4042 
(cherry picked from commit 9045199)

Co-authored-by: twisteroid ambassador <twisteroidambassador@users.noreply.github.com>

bedevere-bot commented Jul 30, 2018

Copy link
Copy Markdown

GH-8575 is a backport of this pull request to the 3.7 branch.

asvetlov commented Jul 30, 2018

Copy link
Copy Markdown
Contributor

thanks!

miss-islington added a commit that referenced this pull request Jul 30, 2018
bpo-33833: Fix ProactorSocketTransport AssertionError (GH-7893)
d5c75be 
(cherry picked from commit 9045199)

Co-authored-by: twisteroid ambassador <twisteroidambassador@users.noreply.github.com>

GoldenOne1 commented Jul 30, 2018

Copy link
Copy Markdown

Will this fix available in version 3.7.1 ?

1st1 commented Jul 30, 2018

Copy link
Copy Markdown
Member

Yes

GoldenOne1 commented Jul 31, 2018

Copy link
Copy Markdown

@1st1

Maintenance releases 3.7.1
Expected: 2018-07-xx

Today is 2018/07/31

twisteroidambassador commented Jul 31, 2018

Copy link
Copy Markdown
Contributor Author

Maintenance releases 3.7.1
Expected: 2018-07-xx

Today is 2018/07/31

The fact that on the last day of 2018-07 the "Expected" date is still not a specific date means, I have to assume, that 3.7.1 will miss its target and will not be released in 2018-07. So don't worry just yet.

@1st1 I'm interested, but probably not yet capable of doing a refactor properly. ;-) I'll work my way there.

twisteroidambassador mannequin mentioned this pull request Apr 10, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1st1 1st1 approved these changes
asvetlov asvetlov approved these changes

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL