bpo-33967: singledispatch raises TypeError when no positional arguments by corona10 · Pull Request #8184 · python/cpython · GitHub

https://bugs.python.org/issue33967

I think this is too much.

I think this is enough:

if not args:
    raise TypeError("singledispatch requires at least 1 positional argument")

True, both f(x=3) and g(*args) can be called with one argument, so shouldn't be rejected. I think @methane's solution does the right thing.

Okay can I update this PR into suggested one?

@doerwalter @methane

Updated! Please take a look!

Test seems too redundant for now.
TypeError happens always when no positional arguments.
How the generic function defined is not important.

f"{func.__name__} requires at least 1 positional argument" may be better, if we can assume func.__name__ is available always.

I believe singledispatch requires positional argument by design, intentionally.
But I want @ambv review before merge.

@methane
Thanks for the quick review.
Updated!
One more thing, we need to add tags needs backport to 3.7 / 3.6.

Error message is not important here. (We won't backport such improvements)

functools.singledispatch now raises TypeError instead of IndexError when no
positional arguments are passed.

@methane I've updated news

func can be not having the __name__ attribute in general case. This PR can break a code which use singledispatch() with custom callables.

Also this change creates a new reference to func linked to from wrapper. It may be better to keep a reference just to the name. E.g.

funcname = getattr(func, '__name__', 'singledispatch function')
def wrapper(*args, **kw):
    # use funcname

I fixed it

Thanks @corona10 for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

GH-8220 is a backport of this pull request to the 3.7 branch.

…H-8184) (cherry picked from commit 445f1b3) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

GH-8221 is a backport of this pull request to the 3.6 branch.

…H-8184) (cherry picked from commit 445f1b3) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

(cherry picked from commit 445f1b3) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

assertRaisesRegexp() is deprecated, so this test fails when test_functools is run with -Werror (see #8261).

corona10 requested review from ncoghlan and rhettinger as code owners July 8, 2018 09:51

the-knights-who-say-ni added the CLA signed label Jul 8, 2018

bedevere-bot added the awaiting review label Jul 8, 2018

methane requested a review from ambv July 9, 2018 09:15

corona10 force-pushed the bpo-33967 branch from 4f72f83 to 0962fd3 Compare July 9, 2018 11:28

methane reviewed Jul 9, 2018

View reviewed changes

corona10 force-pushed the bpo-33967 branch from 0962fd3 to 7aad76b Compare July 9, 2018 12:00

methane changed the title bpo-33967: Improve functools.singledispatch exception messages bpo-33967: singledispatch raises TypeError when no positional arguments Jul 9, 2018

methane reviewed Jul 9, 2018

View reviewed changes

methane added type-bug An unexpected behavior, bug, or error needs backport to 3.6 labels Jul 9, 2018

corona10 force-pushed the bpo-33967 branch from 7aad76b to 26d4234 Compare July 9, 2018 13:45

serhiy-storchaka reviewed Jul 9, 2018

View reviewed changes

bpo-33967: functools.singledispatch now raises TypeError

8730dbd

corona10 force-pushed the bpo-33967 branch from 26d4234 to 8730dbd Compare July 10, 2018 02:15

serhiy-storchaka approved these changes Jul 10, 2018

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jul 10, 2018

methane merged commit 445f1b3 into python:master Jul 10, 2018

bedevere-bot removed the awaiting merge label Jul 10, 2018

bedevere-bot removed the needs backport to 3.7 label Jul 10, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2018

bpo-33967: Fix singledispatch raised IndexError when no args (pythonG…

74b26a1

…H-8184) (cherry picked from commit 445f1b3) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

bedevere-bot removed the needs backport to 3.6 label Jul 10, 2018

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 10, 2018

bpo-33967: Fix singledispatch raised IndexError when no args (pythonG…

a09058c

…H-8184) (cherry picked from commit 445f1b3) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

miss-islington added a commit that referenced this pull request Jul 10, 2018

bpo-33967 : Fix singledispatch raised IndexError when no args (GH-8184 )

df9f633

(cherry picked from commit 445f1b3) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

miss-islington added a commit that referenced this pull request Jul 10, 2018

bpo-33967 : Fix singledispatch raised IndexError when no args (GH-8184 )

6ceab46

(cherry picked from commit 445f1b3) Co-authored-by: Dong-hee Na <donghee.na92@gmail.com>

ZackerySpytz reviewed Jul 12, 2018

View reviewed changes

corona10 deleted the bpo-33967 branch November 22, 2018 11:21

+                      def f(*args):
+                          pass
+                      msg = 'f requires at least 1 positional argument'
+                      with self.assertRaisesRegexp(TypeError, msg):

bpo-33967: singledispatch raises TypeError when no positional arguments by corona10 · Pull Request #8184 · python/cpython · GitHub

Uh oh!

Uh oh!

bpo-33967: singledispatch raises TypeError when no positional arguments - #8184

bpo-33967: singledispatch raises TypeError when no positional arguments#8184methane merged 1 commit intopython:masterpython/cpython:masterfrom corona10:bpo-33967corona10/cpython:bpo-33967Copy head branch name to clipboard

Conversation

corona10 commented Jul 8, 2018 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

methane commented Jul 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

doerwalter commented Jul 9, 2018

Uh oh!

corona10 commented Jul 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

corona10 commented Jul 9, 2018

Uh oh!

methane Jul 9, 2018

Choose a reason for hiding this comment

Uh oh!

methane commented Jul 9, 2018

Uh oh!

corona10 commented Jul 9, 2018

Uh oh!

methane Jul 9, 2018

Choose a reason for hiding this comment

Uh oh!

corona10 commented Jul 9, 2018

Uh oh!

serhiy-storchaka Jul 9, 2018

Choose a reason for hiding this comment

Uh oh!

serhiy-storchaka Jul 9, 2018

Choose a reason for hiding this comment

Uh oh!

corona10 commented Jul 10, 2018

Uh oh!

miss-islington commented Jul 10, 2018

Uh oh!

bedevere-bot commented Jul 10, 2018

Uh oh!

bedevere-bot commented Jul 10, 2018

Uh oh!

ZackerySpytz Jul 12, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

bpo-33967: singledispatch raises TypeError when no positional arguments#8184
methane merged 1 commit into
python:masterfrom
corona10:bpo-33967

corona10 commented Jul 8, 2018 •
edited by bedevere-bot
Loading

methane commented Jul 9, 2018 •
edited
Loading

corona10 commented Jul 9, 2018 •
edited
Loading