FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[WIP] gh-73858: Save and restore module warning registries in catch_warnings by segevfiner · Pull Request #8232 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

[WIP] gh-73858: Save and restore module warning registries in catch_warnings - #8232

Draft
segevfiner wants to merge 5 commits into
python:mainfrom
segevfiner:bpo-29672-catch-warnings-registries-restore
ConversationCommits (5)ChecksFiles changed
Draft

[WIP] gh-73858: Save and restore module warning registries in catch_warnings#8232
segevfiner wants to merge 5 commits into
python:mainfrom
segevfiner:bpo-29672-catch-warnings-registries-restore

Conversation

segevfiner commented Jul 10, 2018 •
edited by serhiy-storchaka
Loading

Copy link
Copy Markdown
Contributor

This avoids catch_warnings wiping out all module warning registries due to calling _filters_mutated. Which causes all warnings recorded in those registries to be shown again.

I'm not sure if this is the right approach for this, so I'm submitting this incomplete in order to garner feedback, and for answers to the questions in TODO below.

TODO

  • Should onceregistry be saved and restored too?
  • A better test? I'm not sure how to test this better since catch_warnings is used for the warnings tests themselves.
  • Consider the order that things are done in catch_warnings.__enter__ and catch_warnings.__exit__, to cause the least disturbance due to threads (It's not thread safe anyhow...)
  • Documentation & NEWS.d obviously

https://bugs.python.org/issue29672

bpo-29672: Save and restore module warning registries in catch_warnings
64ceef9 
This avoids catch_warnings wiping out all module warning registries due
to calling _filters_mutated. Which causes all warnings recorded in those
registries to be shown again.
segevfiner force-pushed the bpo-29672-catch-warnings-registries-restore branch from 041d004 to 64ceef9 Compare July 15, 2018 16:28
gerritholl added a commit to FIDUCEO/FCDR_HIRS that referenced this pull request Oct 12, 2018
Prevent entering catch_warnings
c41a7e2 
Prevent entering catch_warnings so I don't get the same error printed over
and over again.  See https://bugs.python.org/issue29672 and
python/cpython#8232
gerritholl mentioned this pull request Oct 12, 2018
Merged
ZackerySpytz reviewed Nov 29, 2018
View reviewed changes
Comment thread Python/_warnings.c
gerritholl mentioned this pull request Feb 25, 2021
Merged
3 tasks done

patnr commented Mar 4, 2021

Copy link
Copy Markdown

Not sure if bumping is appropriate, but here's hoping for a resolution to this soon!

Here's how I became aware of it.
https://stackoverflow.com/questions/66388579

gerritholl mannequin mentioned this pull request Nov 2, 2022
Open
Carreau mentioned this pull request Sep 26, 2023
Merged
Czaki mentioned this pull request Oct 27, 2023
Merged
jrmylow mentioned this pull request Nov 3, 2023
Open
2 of 3 tasks

anmyachev commented Nov 4, 2023

Copy link
Copy Markdown

Hi @segevfiner do you plan to continue working on this pull request? Or are you waiting for a review?

I ask because I also encountered this problem and I wonder if it can be solved in the near future.

segevfiner commented Nov 13, 2023

Copy link
Copy Markdown
Contributor Author

Hi @segevfiner do you plan to continue working on this pull request? Or are you waiting for a review?

I ask because I also encountered this problem and I wonder if it can be solved in the near future.

It was waiting for a full review since a long time ago (2018...), and seems to have gone stale quite a bit by now. I can try to resolve the conflicts, but even then, I'm not sure any core maintainer will review this

serhiy-storchaka marked this pull request as draft January 17, 2024 20:07

rhshadrach commented Jan 24, 2024

Copy link
Copy Markdown

but even then, I'm not sure any core maintainer will review this

I imagine this has a wide impact, we've gotten numerous issues raised in pandas. As the linked issue points out, one can hit this from the standard library too. I don't understand why it wouldn't be reviewed, but maybe there is some way we can drum up support?

github-actions Bot commented Sep 21, 2024

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 21, 2024
StrawberryOwl mentioned this pull request Feb 3, 2025
Closed
2 of 3 tasks
serhiy-storchaka changed the title [WIP] bpo-29672: Save and restore module warning registries in catch_warnings [WIP] gh-73858: Save and restore module warning registries in catch_warnings Aug 12, 2026
github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner
1 more reviewer
ZackerySpytz ZackerySpytz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL