FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-33967: Remove use of deprecated assertRaisesRegexp() by ZackerySpytz · Pull Request #8261 · python/cpython · GitHub

/ cpython Public

bpo-33967: Remove use of deprecated assertRaisesRegexp() #8261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 3 commits into from
Jul 12, 2018
Conversation 7 Commits 3 Checks 0 Files changed
Merged

bpo-33967: Remove use of deprecated assertRaisesRegexp() #8261

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25ff803
bpo-33967: Fix use of deprecated assertRaisesRegexp() in test_functools
ZackerySpytz Jul 12, 2018
37071b6
Update test_functools.py
methane Jul 12, 2018
29fb9a2
Update test_functools.py
ZackerySpytz Jul 12, 2018
File filter

Filter by extension

Filter by extension .py  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion Lib/test/test_functools.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -2310,7 +2310,7 @@ def test_invalid_positional_argument(self):
def f(*args):
pass
msg = 'f requires at least 1 positional argument'
with self.assertRaisesRegexp(TypeError, msg):
with self.assertRaises(TypeError, msg=msg):

serhiy-storchaka Jul 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This is not correct use of msg. The correct code is:

with self.assertRaisesRegex(TypeError, msg):

The msg argument of assertRaises() is used for reporting a failure. But it should be used for testing the error message.

vstinner Jul 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If the code looks wrong, you should reopen https://bugs.python.org/issue33967 and comment there, otherwise your comment may be lost.

methane Jul 17, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm sorry. It was my mistake.
f()

if __name__ == '__main__':
Expand Down
Back | FazBrowse Home | New Git URL