FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-34154: Fix the docstring of the Listbox class. by noahhaasis · Pull Request #8379 · python/cpython · GitHub

Repository navigation

bpo-34154: Fix the docstring of the Listbox class. - #8379

Closed
noahhaasis wants to merge 5 commits into
python:masterfrom
noahhaasis:fix-issue-34154
Closed

noahhaasis wants to merge 5 commits into
python:masterfrom
noahhaasis:fix-issue-34154

Conversation

noahhaasis commented Jul 21, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This adds the valid keyword arguments for the init function to it's docstring.

https://bugs.python.org/issue34154

Added missing keywordarguments for following classes:
TopLevel, Checkbutton, Entry, Frame, Label, Radiobutton, Text, Spinbox

Copy link
Copy Markdown
Contributor

@noahhaasis Can you please include the additional changes that were part of #8396? Thanks!

csabella left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@noahhaasis Can you please include the additional changes that were part of #8396? Thanks!

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Copy link
Copy Markdown
Contributor

@noahhaasis, I'm going to close this since there's been no response to the code review. If you come back to this at some point, we can re-open it. Thank you for your work!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL