FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[WIP] bpo-17870: Add support for C intmax_t type by vstinner · Pull Request #857 · python/cpython · GitHub

/ cpython Public

[WIP] bpo-17870: Add support for C intmax_t type - #857

Closed
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:intmax
ConversationCommits (1)ChecksFiles changed
Closed

[WIP] bpo-17870: Add support for C intmax_t type#857
vstinner wants to merge 1 commit into
python:masterfrom
vstinner:intmax

Conversation

vstinner commented Mar 27, 2017

Copy link
Copy Markdown
Member

  • Add new conversions functions for PyLong:

    • PyLong_FromIntMax()
    • PyLong_FromUIntMax()
    • PyLong_AsIntMax()
    • PyLong_AsIntMaxAndOverflow()
    • PyLong_AsUIntMax()

  • getargs: add 'm' format

  • New _testcapi constants: INTMAX_MAX, INTMAX_MIN, UINTMAX_MAX, SIZEOF_INTMAX_T

  • Add _testcapi.getargs_m() and _testcapi.test_long_intmax_api()

  • PyLong_FromVoidPtr() uses PyLong_FromUIntMax()

  • Use intmax_t in various modules

array, struct, ctypes and memoryview are not modified yet to support
intmax_t.

bpo-17870: Add support for C intmax_t type
4cfe7f8 
* Add new conversions functions for PyLong:

  - PyLong_FromIntMax()
  - PyLong_FromUIntMax()
  - PyLong_AsIntMax()
  - PyLong_AsIntMaxAndOverflow()
  - PyLong_AsUIntMax()

* getargs: add 'm' format
* New _testcapi constants: INTMAX_MAX, INTMAX_MIN, UINTMAX_MAX, SIZEOF_INTMAX_T
* Add _testcapi.getargs_m() and _testcapi.test_long_intmax_api()
* PyLong_FromVoidPtr() uses PyLong_FromUIntMax()
* Use intmax_t in various modules

array, struct, ctypes and memoryview are not modified yet to support
intmax_t.
serhiy-storchaka reviewed Mar 28, 2017
View reviewed changes
Comment thread Doc/c-api/arg.rst
Convert a Python integer to a C :c:type:`Py_ssize_t`.

``m`` (:class:`int`) [intmax_t]
Convert a Python integer to a C :c:type:`intmax_t`.

serhiy-storchaka Mar 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

What about uintmax_t?

Comment thread Modules/_lzmamodule.c
would not work correctly on platforms with 32-bit longs. */
static int
module_add_int_constant(PyObject *m, const char *name, long long value)
module_add_int_constant(PyObject *m, const char *name, intmax_t value)

serhiy-storchaka Mar 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm sure 64 bit is enough for all LZMA constants.

Comment thread Modules/mmapmodule.c
if (self->file_handle != INVALID_HANDLE_VALUE) {
DWORD low,high;
long long size;
intmax_t size;

serhiy-storchaka Mar 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

size is a 64-bit number. long long is enough.

Comment thread Modules/_tkinter.c
if (Tcl_GetWideIntFromObj(Tkapp_Interp(tkapp), value, &wideValue) == TCL_OK) {
if (sizeof(wideValue) <= SIZEOF_LONG_LONG)
return PyLong_FromLongLong(wideValue);
if (sizeof(wideValue) <= SIZEOF_INTMAX_T) {

serhiy-storchaka Mar 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think this condition is always true. I think that it is always true even for long long. I added this check only because the support of long long was optional.

Comment thread Modules/posixmodule.c
@@ -11414,11 +11387,7 @@ os_DirEntry_inode_impl(DirEntry *self)
Py_BUILD_ASSERT(sizeof(unsigned long long) >= sizeof(self->win32_file_index));
return PyLong_FromUnsignedLongLong(self->win32_file_index);

serhiy-storchaka Mar 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Shouldn't be used PyLong_FromUIntMax?

Comment thread Modules/posixmodule.c
#else
return PyLong_FromLong((long)self->d_ino);
#endif
return PyLong_FromUIntMax((long)self->d_ino);

serhiy-storchaka Mar 28, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(long)?

Can d_ino be negative?

brettcannon added the type-feature A feature request or enhancement label Mar 28, 2017

vstinner commented Jun 14, 2017

Copy link
Copy Markdown
Member Author

Rejected for the reasons explained in the bpo: http://bugs.python.org/issue17870

vstinner closed this Jun 14, 2017
vstinner deleted the intmax branch June 14, 2017 21:31
ssbr mannequin mentioned this pull request Nov 28, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

serhiy-storchaka serhiy-storchaka left review comments

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL