FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

bpo-19569: Add a macro to suppress deprecation warnings (counterpart of Py_DEPRECATED()) by ZackerySpytz · Pull Request #9004 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

bpo-19569: Add a macro to suppress deprecation warnings (counterpart of Py_DEPRECATED()) - #9004

Merged
methane merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-19569-macro-depr-suppress
Jun 16, 2020
ConversationCommits (3)ChecksFiles changed
Merged

bpo-19569: Add a macro to suppress deprecation warnings (counterpart of Py_DEPRECATED())#9004
methane merged 3 commits into
python:masterfrom
ZackerySpytz:bpo-19569-macro-depr-suppress

Conversation

ZackerySpytz commented Aug 29, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

Co-Authored-By: Arfrever Frehtes Taifersar Arahesis arfrever.fta@gmail.com

https://bugs.python.org/issue19569

bpo-19569: Add a macro to suppress deprecation warnings (counterpart …
b57ceb2 
…of Py_DEPRECATED())

Co-Authored-By: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
jdemeyer reviewed Aug 5, 2019
View reviewed changes

jdemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think you should explain more clearly why this is needed.

ZackerySpytz commented Aug 8, 2019

Copy link
Copy Markdown
Contributor Author

These macros can be used to locally suppress deprecation warnings if a deprecated C API function needs to be used. There was some relevant discussion on the BPO issue.

jdemeyer commented Aug 9, 2019

Copy link
Copy Markdown
Contributor

There was some relevant discussion on the BPO issue.

Could you give a more concrete pointers? I didn't find the justification for this PR.

methane commented Jun 15, 2020

Copy link
Copy Markdown
Member

Could you give a more concrete pointers? I didn't find the justification for this PR.

When I uncomment Py_DEPRECATED macros in Include/cpython/unicodeobject.h,
I see some warning in _testcapimodule.c.

methane mentioned this pull request Jun 15, 2020
Merged

methane commented Jun 15, 2020

Copy link
Copy Markdown
Member

It seems these macros are too much.
I just want a Py_SUPRESS_DEPRECATED_DECLS macro.

methane commented Jun 15, 2020

Copy link
Copy Markdown
Member

@ZackerySpytz Would you make these macros private? (e.g. adding _ prefix).
I want to use it in Python 3.9, but I don't want to add public API to 3.9.

methane merged commit de4304d into python:master Jun 16, 2020

miss-islington commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

Thanks @ZackerySpytz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

bedevere-bot commented Jun 16, 2020

Copy link
Copy Markdown

GH-20907 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2020
bpo-19569: Add a macro to suppress deprecation warnings (pythonGH-9004)
ffca914 
Co-authored-by: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
(cherry picked from commit de4304d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
miss-islington added a commit that referenced this pull request Jun 17, 2020
bpo-19569: Add a macro to suppress deprecation warnings (GH-9004)
2c6d6c1 
Co-authored-by: Arfrever Frehtes Taifersar Arahesis <arfrever.fta@gmail.com>
(cherry picked from commit de4304d)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jdemeyer jdemeyer left review comments
serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL