bpo-8110: Refactor platform detection in subprocess - #9053
Merged
zware merged 1 commit intoSep 10, 2018
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Check for functionality via imports rather than checking sys.platform specifically for Windows
vstinner
approved these changes
Sep 4, 2018
vstinner
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM.
Sorry, something went wrong.
pppery
reviewed
Sep 8, 2018
Comment thread
Lib/subprocess.py
| try: | ||
| import msvcrt | ||
| import _winapi | ||
| _mswindows = True |
Copy link
Copy Markdown
There was a problem hiding this comment.
Shouldn't this be in the "else" block?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
The _mswindows = True? sure, it could be. But it doesn't matter.
Sorry, something went wrong.
gpshead
approved these changes
Sep 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for functionality via imports rather than checking sys.platform
specifically for Windows
https://bugs.python.org/issue8110