Repository navigation
gh-69093: Add mapping protocol support to sqlite3.Blob - #91599
Merged
JelleZijlstra merged 10 commits intoApr 22, 2022
Merged
JelleZijlstra merged 10 commits into
JelleZijlstra merged 10 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Authored-by: Aviv Palivoda <palaviv@gmail.com> Co-authored-by: Erlend E. Aasland <erlend.aasland@innova.no>
erlend-aasland
force-pushed
the
sqlite-blob-add-mapping-protocol
branch
from
a84e0fb to
38b2cdb
Compare
April 16, 2022 07:15
Copy link
Copy Markdown
Member
Done, could you fix the conflict? I'll also review the code for this one now. |
Sorry, something went wrong.
Comment thread
Modules/_sqlite/blob.c
Outdated
Comment thread
Modules/_sqlite/blob.c
Outdated
Comment thread
Modules/_sqlite/blob.c
erlend-aasland
marked this pull request as draft
April 16, 2022 17:56
erlend-aasland
marked this pull request as ready for review
April 17, 2022 07:53
Comment thread
Doc/library/sqlite3.rst
Outdated
erlend-aasland
commented
Apr 18, 2022
Comment thread
Lib/test/test_sqlite3/test_dbapi.py
JelleZijlstra
self-requested a review
April 18, 2022 22:25
Comment thread
Lib/test/test_sqlite3/test_dbapi.py
Comment thread
Lib/test/test_sqlite3/test_dbapi.py
Comment thread
Misc/NEWS.d/next/Library/2022-04-14-01-00-31.gh-issue-69093.bmlMwI.rst
Outdated
Comment thread
Modules/_sqlite/blob.c
Outdated
…lMwI.rst Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
vstinner
reviewed
Apr 19, 2022
Comment thread
Lib/test/test_sqlite3/test_dbapi.py
JelleZijlstra
approved these changes
Apr 22, 2022
Copy link
Copy Markdown
Contributor
Author
|
Thanks a lot, Jelle! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally written by @palaviv in gh-271.
Authored-by: Aviv Palivoda palaviv@gmail.com
Co-authored-by: Erlend E. Aasland erlend.aasland@innova.no
gh-69093