FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-84461: Add ability for multiprocessed libregrtest to use a different Python executable by emmatyping · Pull Request #91930 · python/cpython · GitHub

/ cpython Public

gh-84461: Add ability for multiprocessed libregrtest to use a different Python executable - #91930

Merged
brettcannon merged 3 commits into
python:mainfrom
emmatyping:test_host_python
May 2, 2022
ConversationCommits (3)ChecksFiles changed
Merged

gh-84461: Add ability for multiprocessed libregrtest to use a different Python executable#91930
brettcannon merged 3 commits into
python:mainfrom
emmatyping:test_host_python

Conversation

emmatyping commented Apr 25, 2022 •
edited by brettcannon
Loading

Copy link
Copy Markdown
Member

wasm32-emscripten does not support subprocesses. As a workaround, we can run the regression test suite with e.g. the system-native Python used for cross building, then execute the actual subprocess workers with the emscripten/target runtime.

For example, consider a setup where you have two folders: linux, which includes a build of CPython for linux and the native architecture of the machine. You also have wasm, which is the cross compiled Python for emscripten/node.

This PR would enable you to do linux/python -m test -j1 -p "node wasm/python.js", to run the test suite workers in nodejs.

emmatyping mentioned this pull request Apr 26, 2022
Merged
4 tasks

brettcannon commented May 2, 2022

Copy link
Copy Markdown
Member

@ethanhs can you add a news file?

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

1 similar comment

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

2 similar comments

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

2 similar comments

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

@ethanhs: Status check is done, and it's a success ✅ .

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: Head branch was modified. Review and try the merge again..

brettcannon merged commit aff8c4f into python:main May 2, 2022
emmatyping deleted the test_host_python branch May 8, 2022 02:13
tiran mentioned this pull request Jun 21, 2022
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

brettcannon brettcannon approved these changes
tiran Awaiting requested review from tiran

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL