gh-84461: Add HOSTRUNNER for program to run Python executable - #91931
Merged
miss-islington merged 6 commits intoApr 28, 2022
Merged
gh-84461: Add HOSTRUNNER for program to run Python executable#91931miss-islington merged 6 commits into
miss-islington merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
4 tasks
tiran
reviewed
Apr 27, 2022
tiran
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
- Add [] around arguments.
- Fix whitespace / tab
- You need to AC_SUBST variables to make configure substitute the variable in templates.
- Threaded builds need additional arguments to enable experimental threading and shared buffers
AS_VAR_IF([enable_wasm_pthreads], [yes], [ HOSTRUNNER='node --experimental-wasm-threads --experimental-wasm-bulk-memory' ], [ HOSTRUNNER='node' ])
Sorry, something went wrong.
Comment thread
configure.ac
Outdated
Comment thread
configure.ac
Outdated
Comment thread
configure.ac
Outdated
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Christian Heimes <christian@python.org>
Co-authored-by: Christian Heimes <christian@python.org>
tiran
reviewed
Apr 27, 2022
Comment thread
configure.ac
Outdated
Co-authored-by: Christian Heimes <christian@python.org>
tiran
approved these changes
Apr 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOSTRUNNER is a program which can be used to run BUILDPYTHON for the host platform (for example, python.js requires node).
Also change depedencies from build_all to all so that targets which can't build everything (e.g. WASM) can still run buildbottest and pythoninfo.
cc @tiran
Automerge-Triggered-By: GH:tiran