Rephrase typing.assert_never docs - #92061
Merged
JelleZijlstra merged 2 commits intoApr 30, 2022
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This change is similar to that in python#32069
hauntsaninja
requested review from
Fidget-Spinner,
JelleZijlstra and
gvanrossum
as code owners
April 29, 2022 23:13
Copy link
Copy Markdown
Member
|
Maybe line 2361 could also be changed: "succeed" -> "pass a type check"? |
Sorry, something went wrong.
AlexWaygood
approved these changes
Apr 29, 2022
AlexWaygood
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice!
Sorry, something went wrong.
JelleZijlstra
approved these changes
Apr 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is similar to that in #32069
The goal here is to reduce potential confusion between
assert_never(val) and assert False