FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-92106: Add test that subscription works on arbitrary TypedDicts by serhiy-storchaka · Pull Request #92176 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-92106: Add test that subscription works on arbitrary TypedDicts - #92176

Merged
JelleZijlstra merged 1 commit into
python:mainfrom
serhiy-storchaka:typing-typeddict-non-generic-subscript
May 2, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-92106: Add test that subscription works on arbitrary TypedDicts#92176
JelleZijlstra merged 1 commit into
python:mainfrom
serhiy-storchaka:typing-typeddict-non-generic-subscript

Conversation

serhiy-storchaka commented May 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

serhiy-storchaka added tests Tests in the Lib/test dir skip news labels May 2, 2022
JelleZijlstra merged commit 81fb354 into python:main May 2, 2022
This was referenced May 2, 2022
Closed
Closed

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka and @JelleZijlstra, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 81fb3548be5a18bf40a6f4505a02cc7fb72c9c34 3.9

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
pythongh-92106: Add test that subscription works on arbitrary TypedDi…
1589aa2 
…cts (pythonGH-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

JelleZijlstra commented May 2, 2022

Copy link
Copy Markdown
Member

Backporting this since it's purely a tests change.

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

GH-92200 is a backport of this pull request to the 3.10 branch.

miss-islington commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

GH-92201 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
pythongh-92106: Add test that subscription works on arbitrary TypedDi…
24cf08f 
…cts (pythonGH-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request May 3, 2022
gh-92106: Add test that subscription works on arbitrary TypedDicts (G…
adc06cd 
…H-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request May 3, 2022
gh-92106: Add test that subscription works on arbitrary TypedDicts (G…
7e55730 
…H-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
pythongh-92106: Add test that subscription works on arbitrary TypedDi…
bfcabad 
…cts (pythonGH-92176)

(cherry picked from commit 81fb354)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka deleted the typing-typeddict-non-generic-subscript branch July 1, 2026 16:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees

JelleZijlstra

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL