FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-87452 Making returncode unreliability explicit by zitterbewegung · Pull Request #92181 · python/cpython · GitHub

/ cpython Public

gh-87452 Making returncode unreliability explicit - #92181

Merged
gpshead merged 19 commits into
python:mainfrom
zitterbewegung:gh-87452
Apr 24, 2023
ConversationCommits (19)ChecksFiles changed
Merged

gh-87452 Making returncode unreliability explicit#92181
gpshead merged 19 commits into
python:mainfrom
zitterbewegung:gh-87452

Conversation

zitterbewegung commented May 2, 2022 •
edited by terryjreedy
Loading

Copy link
Copy Markdown
Contributor

We make explicit that the value stored in return code is best returned by poll instead of using the value in return code.

gh-87452: Making returncode unreliability explicit

bedevere-bot commented May 2, 2022

Copy link
Copy Markdown

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 2, 2022
zitterbewegung changed the title Making returncode unreliability explicit gh-87452 Making returncode unreliability explicit May 2, 2022

benjaminp commented May 2, 2022

Copy link
Copy Markdown
Contributor

Thank you for the PR.

I don't think "out-of-date" is the right term here. Either the entire subprocess.Subprocess instance is aware of the exit of the child process and knows the return code, or it doesn't. The first paragraph of the method documentation could perhaps be rearranged to more clearly state the order of events instead of appending another sentence.

benjaminp commented May 2, 2022

Copy link
Copy Markdown
Contributor

I would propose:

The child return code. Initially ``None``, :attr:`returncode` is set by :meth:`poll` and :meth:`wait` after process termination is observed.
``

benjaminp reviewed May 2, 2022
View reviewed changes
Comment thread Doc/library/subprocess.rst Outdated
Comment thread Doc/library/subprocess.rst Outdated

erlend-aasland commented May 3, 2022

Copy link
Copy Markdown
Contributor

Please remove the duplicate NEWS entry.

slateny reviewed Oct 13, 2022
View reviewed changes
Comment thread Doc/library/subprocess.rst Outdated
arhadthedev reviewed Oct 13, 2022
View reviewed changes
Comment thread Doc/library/subprocess.rst Outdated
Update Doc/library/subprocess.rst
4adaaab 
Co-authored-by: Oleg Iarygin <dralife@yandex.ru>
erlend-aasland requested changes Oct 14, 2022
View reviewed changes

erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Again, please remove the duplicate NEWS entry. Also please address Benjamin's remarks.

Comment thread Doc/library/subprocess.rst Outdated

bedevere-bot commented Oct 14, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

slateny commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

@zitterbewegung Would you still be interested in giving the PR a quick update per the reviews above?

zitterbewegung commented Dec 6, 2022

Copy link
Copy Markdown
Contributor Author

Sorry I can do that.

bedevere-bot mentioned this pull request Dec 6, 2022
Closed

netlify Bot commented Dec 6, 2022 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for python-cpython-preview ready!

Name Link
🔨 Latest commit 41a5d22
🔍 Latest deploy log https://app.netlify.com/sites/python-cpython-preview/deploys/638f5503b72cc30008de175b
😎 Deploy Preview https://deploy-preview-92181--python-cpython-preview.netlify.app/whatsnew/changelog
📱 Preview on mobile Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

zitterbewegung commented Dec 6, 2022
View reviewed changes

zitterbewegung left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
  • Fixed word wrap issue
  • Removed duplicate news entry.

hugovk mentioned this pull request Dec 6, 2022
Merged
zitterbewegung commented Dec 6, 2022
View reviewed changes

zitterbewegung left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Removed trailing whitespace

zitterbewegung commented Dec 6, 2022

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again.

bedevere-bot commented Dec 6, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

zitterbewegung commented Apr 24, 2023

Copy link
Copy Markdown
Contributor Author

@erlend-aasland can this be reviewed?

gpshead self-assigned this Apr 24, 2023
gpshead merged commit 68f5836 into python:main Apr 24, 2023

miss-islington commented Apr 24, 2023

Copy link
Copy Markdown
Contributor

Thanks @zitterbewegung for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

erlend-aasland commented Apr 25, 2023

Copy link
Copy Markdown
Contributor

Sorry for the delay; thanks Greg for merging. Thanks for the PR, Joshua.

terryjreedy removed the needs backport to 3.11 only security fixes label Feb 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

benjaminp benjaminp left review comments
arhadthedev arhadthedev left review comments
slateny slateny left review comments
furkanonder furkanonder approved these changes
erlend-aasland Awaiting requested review from erlend-aasland

Assignees

gpshead

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL