FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] gh-80254: Disallow recursive usage of cursors in `sqlite3` converters by erlend-aasland · Pull Request #92278 · python/cpython · GitHub

/ cpython Public

[3.9] gh-80254: Disallow recursive usage of cursors in sqlite3 converters - #92278

Merged
JelleZijlstra merged 3 commits into
python:3.9from
erlend-aasland:backport-sqlite-converter-segfault-3.9
May 5, 2022
Merged

[3.9] gh-80254: Disallow recursive usage of cursors in sqlite3 converters#92278
JelleZijlstra merged 3 commits into
python:3.9from
erlend-aasland:backport-sqlite-converter-segfault-3.9

Conversation

Copy link
Copy Markdown
Contributor

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev fedoseev.sergey@gmail.com
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com

…` converters

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra self-assigned this May 4, 2022
JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit a5b9786 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 4, 2022
erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 8e5fe56 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022

Copy link
Copy Markdown
Contributor Author

For 3.9, 3.8, and 3.7, the cursor is not deallocated implicitly. I checked the code coverage, and the cursor dealloc function never run. Explicitly deleting the cursor in tearDown ensures proper cleanup.

JelleZijlstra merged commit 7d17a7b into python:3.9 May 5, 2022
erlend-aasland deleted the backport-sqlite-converter-segfault-3.9 branch May 5, 2022 20:24
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…` converters (python#92278)

* [3.9] pythongh-80254: Disallow recursive usage of cursors in `sqlite3` converters

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

* Fix ref leak in pysqlite_cursor_iternext

* Explicitly free resources at test tearDown()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL