FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.8] gh-80254: Disallow recursive usage of cursors in sqlite3 converters by erlend-aasland · Pull Request #92333 · python/cpython · GitHub

/ cpython Public

[3.8] gh-80254: Disallow recursive usage of cursors in sqlite3 converters - #92333

Merged
ambv merged 3 commits into
python:3.8from
erlend-aasland:backport-sqlite-converter-segfault-3.8
May 16, 2022
ConversationCommits (3)ChecksFiles changed
Merged

[3.8] gh-80254: Disallow recursive usage of cursors in sqlite3 converters#92333
ambv merged 3 commits into
python:3.8from
erlend-aasland:backport-sqlite-converter-segfault-3.8

Conversation

erlend-aasland commented May 5, 2022

Copy link
Copy Markdown
Contributor

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev fedoseev.sergey@gmail.com
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com

erlend-aasland and others added 3 commits May 4, 2022 23:47
[3.8] pythongh-80254: Disallow recursive usage of cursors in `sqlite3…
2dc3259 
…` converters

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev <fedoseev.sergey@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Fix ref leak in pysqlite_cursor_iternext
fc07267
Explicitly free resources at test tearDown()
88b09dc
erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022

bedevere-bot commented May 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 88b09dc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022
This was referenced May 5, 2022
Merged
Closed

erlend-aasland commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Buildbot comments (updating this post as they complete):

  • AMD64 FreeBSD Shared PR: compile failures; seems unrelated to this PR
  • ARM64 Windows PR: build tools missing; unrelated
  • ARM64 Windows Non-Debug PR: build tools missing; unrelated

JelleZijlstra commented May 5, 2022

Copy link
Copy Markdown
Member

The remaining failures (Gentoo, Fedora, Asan, Usan) are also on tests unrelated to SQLite. I don't have permissions to merge to this branch though.

erlend-aasland commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

FTR, the buildbot failures all seem unrelated. Some are failed builds (missing build tools), others are unrelated test failures.

vstinner commented May 5, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

The 3.8 branch no longer accept bugfixes, only security fixes: https://devguide.python.org/#status-of-python-branches

Do you consider that this change fix a security issue?

JelleZijlstra commented May 5, 2022

Copy link
Copy Markdown
Member

The 3.8 branch no longer accept bugfixes, only security fixes: https://devguide.python.org/#status-of-python-branches

Do you consider that this change fix a security issue?

Yes, because it fixes a segfault. #29054 (comment)

vstinner commented May 5, 2022

Copy link
Copy Markdown
Member

Ok, thanks.

ambv merged commit 69cf020 into python:3.8 May 16, 2022
erlend-aasland deleted the backport-sqlite-converter-segfault-3.8 branch May 16, 2022 17:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra approved these changes
berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner
ambv Awaiting requested review from ambv
+1 more reviewer
Tony-Frank-ML Tony-Frank-ML approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL