FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-92332: Docs-only deprecation of `typing.Text` by AlexWaygood · Pull Request #92351 · python/cpython · GitHub

/ cpython Public

gh-92332: Docs-only deprecation of typing.Text - #92351

Merged
Fidget-Spinner merged 5 commits into
python:mainfrom
AlexWaygood:typing-dot-text
May 6, 2022
ConversationCommits (5)ChecksFiles changed
Merged

gh-92332: Docs-only deprecation of typing.Text#92351
Fidget-Spinner merged 5 commits into
python:mainfrom
AlexWaygood:typing-dot-text

Conversation

AlexWaygood commented May 5, 2022

Copy link
Copy Markdown
Member

Closes #92332

bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 5, 2022
hauntsaninja reviewed May 6, 2022
View reviewed changes
Comment thread Doc/library/typing.rst Outdated
Fidget-Spinner approved these changes May 6, 2022
View reviewed changes

Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks Alex.

Fidget-Spinner commented May 6, 2022

Copy link
Copy Markdown
Member

I'm going to merge this first in case we inadvertently miss the beta freeze cutoff. We can just fix up anything else in the docs if Jelle spots problems later.

Fidget-Spinner merged commit 6f18b86 into python:main May 6, 2022
AlexWaygood deleted the typing-dot-text branch May 6, 2022 10:17

AlexWaygood commented May 6, 2022

Copy link
Copy Markdown
Member Author

I'm going to merge this first in case we inadvertently miss the beta freeze cutoff. We can just fix up anything else in the docs if Jelle spots problems later.

Thanks @Fidget-Spinner 😊

JelleZijlstra reviewed May 6, 2022
View reviewed changes
Comment thread Doc/library/typing.rst
.. deprecated:: 3.11
Python 2 is no longer supported, and most type checkers also no longer
support type checking Python 2 code. Users should now use
:class:`str` instead of ``Text`` wherever possible.

JelleZijlstra May 6, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could we add an explicit note here saying that removal is not currently planned? A "deprecated" note can make users think it will be removed soon.

AlexWaygood May 6, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(For future readers of this PR):

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JelleZijlstra JelleZijlstra left review comments
hauntsaninja hauntsaninja left review comments
Fidget-Spinner Fidget-Spinner approved these changes
gvanrossum Awaiting requested review from gvanrossum

Assignees

No one assigned

Labels

docs Documentation in the Doc dir topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate typing.Text

5 participants

Back | FazBrowse Home | New Git URL