FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[3.9] gh-92417: `doctest` docs: remove references to Python <3.6 (GH-92420) by miss-islington · Pull Request #92492 · python/cpython · GitHub

/ cpython Public

[3.9] gh-92417: doctest docs: remove references to Python <3.6 (GH-92420) - #92492

Closed
miss-islington wants to merge 1 commit into
python:3.9from
miss-islington:backport-5639ea1-3.9
ConversationCommits (1)ChecksFiles changed
Closed

[3.9] gh-92417: doctest docs: remove references to Python <3.6 (GH-92420)#92492
miss-islington wants to merge 1 commit into
python:3.9from
miss-islington:backport-5639ea1-3.9

Conversation

miss-islington commented May 8, 2022

Copy link
Copy Markdown
Contributor

(cherry picked from commit 5639ea1)

Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com

pythongh-92417: doctest docs: remove references to Python <3.6 (pyt…
ef289e0 
…honGH-92420)

(cherry picked from commit 5639ea1)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
miss-islington force-pushed the backport-5639ea1-3.9 branch from 784ea4b to ef289e0 Compare May 8, 2022 16:01

miss-islington commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

bedevere-bot mentioned this pull request May 8, 2022
Merged

miss-islington commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

1 similar comment

miss-islington commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

bedevere-bot added skip news docs Documentation in the Doc dir awaiting review labels May 8, 2022
AlexWaygood mentioned this pull request May 8, 2022
Closed

miss-islington commented May 8, 2022

Copy link
Copy Markdown
Contributor Author

@AlexWaygood and @serhiy-storchaka: Status check is done, and it's a success ✅ .

CAM-Gerlach reviewed May 8, 2022
View reviewed changes

CAM-Gerlach left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(Apparently I can't delete this comment, but I immediately realized I'd been on the wrong tab and accidentally submitted a review on a backport PR right after submitting it instead of the main one. My fault, sorry.)

AlexWaygood commented May 8, 2022

Copy link
Copy Markdown
Member

It looks like there's a chunk of text referring to compatibility with Python <3.2, and workarounds to support Python <2.4, in the description of doctest.EXCEPTION_DETAIL; should that be elided as well? It substantially complicates the description of doctest.IGNORE_EXCEPTION_DETAIL and doesn't seem to be of any use for modern Python, beyond what is already noted in the versionchanged notice.

Let's discuss that over at the issue (#92417) rather than in the comment thread for a backport PR :-)

CAM-Gerlach commented May 8, 2022

Copy link
Copy Markdown
Member

Yes, I'd realized immediately after submitting it but couldn't delete my review, so I ended up just editing it instead. Really sorry about that, I'm a doofus.

AlexWaygood commented May 8, 2022

Copy link
Copy Markdown
Member

Yes, I'd realized immediately after submitting it but couldn't delete my review, so I ended up just editing it instead. Really sorry about that, I'm a doofus.

No reason to be sorry! I'm sure miss-islington appreciates the review :-)

AlexWaygood requested a review from JelleZijlstra May 9, 2022 07:52

rhettinger commented May 9, 2022

Copy link
Copy Markdown
Contributor

Please don't backport these. That is only appropriate for a bug fix.

rhettinger closed this May 9, 2022
miss-islington deleted the backport-5639ea1-3.9 branch May 9, 2022 08:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

CAM-Gerlach CAM-Gerlach left review comments
JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL