| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
Faster is better!
A
Sorry, something went wrong.
|
@hugovk Should we backport to 3.9 and 3.10 too? -j auto was added in Sphinx 1.7, so I don't believe there would be any compatability concerns. A |
Sorry, something went wrong.
|
Yes, labels added. |
Sorry, something went wrong.
|
I'll have to dig into this a bit later, but at first glance it can't be backported to 3.9. I don't remember all the details but in 3.9 we used a non-compatibile sphinx extention (in pyspecific.py). It has been fixed around 3.10. That's why on docs.python.org we only use parallel builds since 3.10: We'll also have to check how it goes with the already present -j4 in build_docs.py, (Yes I'll gladly drop the flag in build_docs.py to use the one from the cpython Makefile). |
Sorry, something went wrong.
Thanks, let's keep it simple and drop the 3.9 backport, this change is mainly beneficial for developers building docs, and I expect that will mostly be main and newer versions.
Yep, what's a good way to check it? |
Sorry, something went wrong.
By running make SPHINXOPTS="-j4" autobuild-dev-html which is mostly what docsbuild-scripts does. And it goes well, so it looks good to me. It starts sphinx-build -b html -d build/doctrees -j auto -j4 -Ea -A daily=1 -W . build/html. we'll just have to remove the -j4 from docsbuild scripts once its merged, but in the meantime sphinx is not surprised by the presence of two -js. |
Sorry, something went wrong.
|
Thanks @hugovk for the PR, and @JulienPalard for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
(cherry picked from commit a487623) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
|
Sorry, @hugovk and @JulienPalard, I could not cleanly backport this to 3.10 due to a conflict. |
Sorry, something went wrong.
|
GH-92847 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
(cherry picked from commit a487623) Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
(cherry picked from commit a487623)
|
GH-92850 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
|
Flag drop from build_docs.py: python/docsbuild-scripts#129 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
sphinx-build has a -j N option:
https://www.sphinx-doc.org/en/master/man/sphinx-build.html#cmdoption-sphinx-build-j
Test on a new 10-core Mac
Results of two runs before
Results of two runs after
That's nearly twice as fast: 1m06s -> 35s
Test on an old dual-core Mac
Results of one run before
Results of one runs before
That's about 1.5x faster: 3m42s -> 2m29s