FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-91860: documentation for typing.dataclass_transform by hauntsaninja · Pull Request #92768 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-91860: documentation for typing.dataclass_transform - #92768

Merged
JelleZijlstra merged 8 commits into
python:mainfrom
hauntsaninja:dataclass-trans
May 20, 2022
ConversationCommits (8)ChecksFiles changed
Merged

gh-91860: documentation for typing.dataclass_transform#92768
JelleZijlstra merged 8 commits into
python:mainfrom
hauntsaninja:dataclass-trans

Conversation

hauntsaninja commented May 13, 2022

Copy link
Copy Markdown
Contributor

No description provided.

bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 13, 2022
AlexWaygood added the needs backport to 3.11 only security fixes label May 13, 2022
AlexWaygood self-requested a review May 13, 2022 09:34
slateny reviewed May 14, 2022
View reviewed changes
Comment thread Doc/library/typing.rst Outdated
AlexWaygood reviewed May 14, 2022
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! A few nitpicks:

Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
Comment thread Doc/library/typing.rst Outdated
JelleZijlstra reviewed May 17, 2022
View reviewed changes

JelleZijlstra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks! I agree with @AlexWaygood's and @slateny's feedback. Also cc @debonte.

Comment thread Doc/library/typing.rst
AlexWaygood reviewed May 17, 2022
View reviewed changes
Comment thread Doc/library/typing.rst Outdated
AlexWaygood reviewed May 17, 2022
View reviewed changes
Comment thread Lib/typing.py Outdated
hauntsaninja and others added 2 commits May 19, 2022 18:47
Update Doc/library/typing.rst
282c194 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Update Lib/typing.py
c30ff07 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
JelleZijlstra merged commit f20a6a5 into python:main May 20, 2022

miss-islington commented May 20, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington commented May 20, 2022

Copy link
Copy Markdown
Contributor

Sorry @hauntsaninja and @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f20a6a54fb041507a334ad71706974960d1b473f 3.11

JelleZijlstra added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 20, 2022

miss-islington commented May 20, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot commented May 20, 2022

Copy link
Copy Markdown

GH-93017 is a backport of this pull request to the 3.11 branch.

bedevere-bot removed the needs backport to 3.11 only security fixes label May 20, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2022
pythongh-91860: documentation for typing.dataclass_transform (pythonG…
9b50e8f 
…H-92768)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit f20a6a5)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 20, 2022
gh-91860: documentation for typing.dataclass_transform (GH-92768)
6a3a6ba 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit f20a6a5)

Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
hauntsaninja deleted the dataclass-trans branch May 22, 2022 07:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

slateny slateny left review comments
JelleZijlstra JelleZijlstra approved these changes
AlexWaygood AlexWaygood approved these changes
gvanrossum Awaiting requested review from gvanrossum
Fidget-Spinner Awaiting requested review from Fidget-Spinner
+1 more reviewer
debonte debonte approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

JelleZijlstra

Labels

docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL