FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-92780: Improve sqlite3.Connection.create_collation docs by erlend-aasland · Pull Request #92790 · python/cpython · GitHub

/ cpython Public

gh-92780: Improve sqlite3.Connection.create_collation docs - #92790

Merged
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-collation-docs
May 18, 2022
ConversationCommits (3)ChecksFiles changed
Merged

gh-92780: Improve sqlite3.Connection.create_collation docs#92790
erlend-aasland merged 3 commits into
python:mainfrom
erlend-aasland:sqlite-collation-docs

Conversation

erlend-aasland commented May 13, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves #92780

bedevere-bot added docs Documentation in the Doc dir awaiting core review labels May 13, 2022

erlend-aasland commented May 13, 2022

Copy link
Copy Markdown
Contributor Author

@AdrianIssott, would you mind reviewing this?

erlend-aasland commented May 13, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst
AlexWaygood reviewed May 14, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
AlexWaygood reviewed May 15, 2022
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
AlexWaygood approved these changes May 15, 2022
View reviewed changes

AlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, other than the mishap with ReST :)

Update Doc/library/sqlite3.rst
8d788da 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AdrianIssott commented May 16, 2022

Copy link
Copy Markdown

LGTM 👍

erlend-aasland commented May 16, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews. I'll merge in a day or two.

erlend-aasland merged commit 7ee19e2 into python:main May 18, 2022

miss-islington commented May 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

erlend-aasland deleted the sqlite-collation-docs branch May 18, 2022 11:44
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2022
pythongh-92780: Improve sqlite3.Connection.create_collation docs (pyt…
ba8993f 
…honGH-92790)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
bedevere-bot removed the needs backport to 3.11 only security fixes label May 18, 2022

bedevere-bot commented May 18, 2022

Copy link
Copy Markdown

GH-92922 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2022
pythongh-92780: Improve sqlite3.Connection.create_collation docs (pyt…
b9bc99d 
…honGH-92790)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
bedevere-bot removed the needs backport to 3.10 only security fixes label May 18, 2022

bedevere-bot commented May 18, 2022

Copy link
Copy Markdown

GH-92923 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 18, 2022
pythongh-92780: Improve sqlite3.Connection.create_collation docs (pyt…
a695ae6 
…honGH-92790)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>

bedevere-bot commented May 18, 2022

Copy link
Copy Markdown

GH-92924 is a backport of this pull request to the 3.9 branch.

erlend-aasland mentioned this pull request May 18, 2022
Closed
miss-islington added a commit that referenced this pull request May 18, 2022
gh-92780: Improve sqlite3.Connection.create_collation docs (GH-92790)
65ebd92 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
miss-islington added a commit that referenced this pull request May 18, 2022
gh-92780: Improve sqlite3.Connection.create_collation docs (GH-92790)
94e21cf 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 7ee19e2)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland mentioned this pull request Apr 24, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AlexWaygood AlexWaygood approved these changes
berkerpeksag Awaiting requested review from berkerpeksag

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3: Connection.create_collation() documentation inaccuracies

5 participants

Back | FazBrowse Home | New Git URL