Repository navigation
gh-92800: Fix C++ _Py_CAST with constant types - #92818
Closed
da-woods wants to merge 3 commits into
Closed
da-woods wants to merge 3 commits into
da-woods wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Thus fixing PyUnicode_READ in C++. Fixes python#92800 I've created a C++ helper struct definition to work out the type with constant added (it's OK to add const to a constant type in typedefs in C++).
Copy link
Copy Markdown
Contributor
Author
|
I think this can be skipped in news. I don't think it's hugely easy to add tests for this specifically - I think this requires Python to be tested with a C++ compiler (which I don't know if it is right now?) I've added a test now I'm not hugely happy with adding a helper struct definition, but I can't see any other easy way to do this. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
This was fixed elsewhere |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thus fixing PyUnicode_READ in C++.
Fixes #92800
I've created a C++ helper struct definition to work out the
type with constant added (it's OK to add const to a constant
type in typedefs in C++).