FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-92536: Compute unicode struct sizes to ensure MemError is raised by sweeneyde · Pull Request #92867 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-92536: Compute unicode struct sizes to ensure MemError is raised - #92867

Merged
sweeneyde merged 1 commit into
python:mainfrom
sweeneyde:unicode_memerror
May 17, 2022
ConversationCommits (1)ChecksFiles changed
Merged

gh-92536: Compute unicode struct sizes to ensure MemError is raised#92867
sweeneyde merged 1 commit into
python:mainfrom
sweeneyde:unicode_memerror

Conversation

sweeneyde commented May 17, 2022

Copy link
Copy Markdown
Member

I believe this is the cause of recent failing x86 Gentoo buildbots.

bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels May 17, 2022
sweeneyde requested a review from methane May 17, 2022 04:09
sweeneyde added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 17, 2022

bedevere-bot commented May 17, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 111ece3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 17, 2022

sweeneyde commented May 17, 2022

Copy link
Copy Markdown
Member Author

Gentoo bots are green for the first time in a little while.

sweeneyde merged commit 19a4252 into python:main May 17, 2022
sweeneyde deleted the unicode_memerror branch May 17, 2022 14:12

ambv commented May 17, 2022

Copy link
Copy Markdown
Contributor

Could this be backported to 3.11 and 3.10?

sweeneyde commented May 17, 2022

Copy link
Copy Markdown
Member Author

Sure, it could, but it's not changing anything there other than clarity. The main reason it matters is that Unicode struct size changed in 3.12 due to PEP 623.

ambv commented May 17, 2022

Copy link
Copy Markdown
Contributor

OK, nevermind then.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

methane methane approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL