gh-93008: refactor compiler functions that add instructions to take only a basicblock* (not the whole compiler) - #93009
Merged
iritkatriel merged 4 commits intoMay 29, 2022
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…ler_use_new_implicit_block_if_needed insted (for the last instr in the block)
…block rather than taking a compiler struct ptr. Rename them to basicblock_add_*
sweeneyde
approved these changes
May 22, 2022
sweeneyde
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Looks correct and makes things a bit more flexible.
Out of interest, what are the use-cases for adding instructions at assembly time?
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Thanks. I need to do this here line 7465. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks good. |
Sorry, something went wrong.
1 similar comment
Copy link
Copy Markdown
Member
|
Looks good. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes these functions available for use in the optimiser and assembler, when it is necessary to change basic blocks.
Closes #93008.